Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config_loader ignores local mss_settings.json #683

Closed
ReimarBauer opened this issue Feb 22, 2021 · 0 comments · Fixed by #684
Closed

config_loader ignores local mss_settings.json #683

ReimarBauer opened this issue Feb 22, 2021 · 0 comments · Fixed by #684
Assignees
@ReimarBauer
Milestone
3.0.0

Comments

@ReimarBauer
Copy link
Member

Likly with the refactoring of the config_loader the initialising of a mss_settings.json was removed.
This needs a review and also tests to cover this behaviour
@ReimarBauer ReimarBauer added this to the 3.0.0 milestone Feb 22, 2021
@ReimarBauer ReimarBauer self-assigned this Feb 22, 2021
@ReimarBauer ReimarBauer changed the title config_loader ignores somehow local mss_settings.json config_loader ignores local mss_settings.json Feb 22, 2021
@ReimarBauer ReimarBauer linked a pull request Feb 22, 2021 that will close this issue
enables config_loader to read the local settings json file on default #684
Merged
ReimarBauer added a commit that referenced this issue Feb 26, 2021
@ReimarBauer @Marilyth @ahelii16
enables config_loader to read the local settings json file on default (…
12a53f4 
…#684)

* Add testing to stable

* Added fix for #642 (#647)

* Added fix for #642

* Fixed import os to fs #642

* Removed comment

* Changed exists statement #642

* Fixed pylint error #642

* Editing mscolab Url must be blocked on connect #637 (#661)

* mscolab disconnect #637

* Removed set editable #637

* Fix conda-forge missing in channels (#666)

* added fixation for geos to <3.9.0, fixes #665 (#668)

* fixes config_loader for local mss_settings, #683

Co-authored-by: May <baermay98@gmail.com>
Co-authored-by: Aheli Ghosh <debjanihome@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ReimarBauer ReimarBauer

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

enables config_loader to read the local settings json file on default
1 participant
@ReimarBauer