Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conftest on windows has problems with backslashes #714

Closed
ReimarBauer opened this issue Mar 12, 2021 · 0 comments · Fixed by #715
Closed

conftest on windows has problems with backslashes #714

ReimarBauer opened this issue Mar 12, 2021 · 0 comments · Fixed by #715
Assignees
@ReimarBauer
Labels
request upstream help

Comments

@ReimarBauer
Copy link
Member

Also our conftest is not optimal currently for windows we found a dependency we asked for help on pyfilesystem2

PyFilesystem/pyfilesystem2#454
@ReimarBauer ReimarBauer added request upstream help upstream fix needed a dependency of us needs an improvement labels Mar 12, 2021
@ReimarBauer ReimarBauer self-assigned this Mar 12, 2021
@ReimarBauer ReimarBauer removed the upstream fix needed a dependency of us needs an improvement label Mar 12, 2021
@ReimarBauer ReimarBauer linked a pull request Mar 12, 2021 that will close this issue
makes conftest useable for windows devs , fixes #714 #715
Merged
ReimarBauer added a commit that referenced this issue Mar 15, 2021
@ReimarBauer
makes conftest useable for windows devs , fixes #714 (#715)
291e3ea 
* use fs.join_path and url_join

* path for windows unified to slash

* we need on windows os.path.join for relative pathes to sample files

* forced multiprocessing start_method fork, disabled tests for windows

we need to refactor mss to be able to use spawn method for windows and
MacOSX

* skip test for windows because of multiprocessing start_method fork

* skip test for windows because of multiprocessing start_method fork

* flake8 fix

* test_editor fixed path issues for windows

* flake8 fix

* solved save_ftml file path issues for windows
risehr added a commit to risehr/MSS that referenced this issue Mar 16, 2021
@risehr
Merge pull request #3 from Open-MSS/develop
51381b5 
makes conftest useable for windows devs , fixes Open-MSS#714 (Open-MSS#715)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ReimarBauer ReimarBauer

Labels
request upstream help
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

makes conftest useable for windows devs , fixes #714
1 participant
@ReimarBauer