[Completed] Automated tutorial for how to create a project in MSS using all the views. #1104

risehr · 2021-07-31T09:07:53Z

This involves the demonstration of how to create a project with all the views, that are, top view, side view, table view and linear view.
I have tested in both windows and linux and it works smoothly.

(The previous PR opened had the random tests failing. Hence, created this new PR and closed the previous #1096 PR)

…iews

Marilyth · 2021-07-31T09:28:00Z

Your tests will probably pass when next merged with develop

risehr · 2021-07-31T09:52:15Z

Your tests will probably pass when next merged with develop

Okay. Thanks.

ReimarBauer

I would like to see a bit modularisation in some utils functions for the different platform parts.

This could also be done in a refactoring PR. What is your opinion about this?

ReimarBauer · 2021-07-31T16:58:32Z

tutorials/tutorial_views.py

+import pyautogui as pag
+import multiprocessing
+import sys
+from sys import platform


When you import "sys" by thee line before, it would make sense to me to use sys.platform

The import sys has a different use such as sys.exit() but the from sys import platform had been done because platform could be independently used as the name suggests for the platforms such as windows or linux or mac.

Should I remove from sys import platform and use only sys.platform??

I think I would unify the usage. you could do

from sys import platform, exit

or use sys.platform

I would use sys.platform because it is already imported and I am used to read sys.exit()

ReimarBauer · 2021-07-31T17:00:06Z

tutorials/tutorial_views.py

+    """
+    This is the main automating script of the MSS views tutorial which will cover all the views(topview, sideview,
+    tableview, linear view) in demonstrating how to create a project. This will be recorded and savedto a file having
+     dateframe nomenclature with a .mp4 extension(codec).


left blank too much?

Again by mistake, Will remove that.

ReimarBauer · 2021-07-31T17:03:01Z

tutorials/tutorial_views.py

+    pag.sleep(2)
+
+    # Shfting topview window to upper right corner
+    try:


comment: usually we do capsulate in try exception blocks only the part of the lines which could make trouble

I have used try except in every part where it is locating an image on the screen to click upon. If the try block would be removed and if it is not able to find the image then the user will not know where the error in program is or it would simply stop the execution.
Wherever there is pag.locateCentreOnScreen() function I have kept it inside the try block and all the following code that is dependent on that image found by the same function.

ReimarBauer · 2021-07-31T17:04:07Z

tutorials/tutorial_views.py

+
+        pag.move(-150, 30, duration=1)
+        x1, y1 = pag.position()
+        # print(x1, y1)


remove not needed comments

Again by mistake. I will remove those. Sorry!

ReimarBauer · 2021-07-31T17:05:13Z

tutorials/tutorial_views.py

+        # Shifting Sideview window to upper left corner.
+        try:
+            x1, y1 = pag.locateCenterOnScreen(f'{dir_path}add_waypoint.png')
+            if platform == 'win32' or platform == 'darwin':


the pag code lines can be moved to a utils functions and has the platform as input value

Okay. I will try to find a way in which it can be done. Since, there are many small things which are platform dependent and even if when added to utils function, somethings still need to be there in the source code regarding platform.

you can do this later, when you have a module ready. I guess it is better readable afterwards.

ReimarBauer · 2021-07-31T17:14:16Z

tutorials/tutorial_views.py

+    pag.sleep(5)
+
+    if platform == 'linux' or platform == 'linux2' or platform == 'darwin':
+        dir_path = 'pictures/tutorial_views/win/'


there could be in utils a pictures functions, similiar to the icons functions which sets the path and also returns the needed image

I will try to do that.

risehr · 2021-07-31T19:12:42Z

I would like to see a bit modularisation in some utils functions for the different platform parts.

This could also be done in a refactoring PR. What is your opinion about this?

Yeah, it would be helpful if I do all those utils' part in another refactoring PR. Moreover, I am thinking to complete the rest tutorials first and then do this refactoring around utils part? Because, I guess I should complete the tutorials first. What say?

…ary comments

ReimarBauer · 2021-07-31T20:09:20Z

I would like to see a bit modularisation in some utils functions for the different platform parts.
This could also be done in a refactoring PR. What is your opinion about this?

Yeah, it would be helpful if I do all those utils' part in another refactoring PR. Moreover, I am thinking to complete the rest tutorials first and then do this refactoring around utils part? Because, I guess I should complete the tutorials first. What say?

Agreed

risehr · 2021-07-31T20:11:40Z

I would like to see a bit modularisation in some utils functions for the different platform parts.
This could also be done in a refactoring PR. What is your opinion about this?

Yeah, it would be helpful if I do all those utils' part in another refactoring PR. Moreover, I am thinking to complete the rest tutorials first and then do this refactoring around utils part? Because, I guess I should complete the tutorials first. What say?

Agreed

Okay then. I am starting my work on mscolab tutorial as of now.

ReimarBauer

Ok Thx

commit 3bd614e Merge: c8b662b 094c388 Author: ReimarBauer <rb.proj@gmail.com> Date: Mon Aug 23 16:35:23 2021 +0200 Merge pull request #1170 from risehr/textfiles Added text files for kml, mscolab, wms, and views tutorials. commit 094c388 Author: Hrithik Kumar Verma <vermahrithik812@gmail.com> Date: Mon Aug 23 19:21:46 2021 +0530 Corrected spelling of MSColab commit 83551be Author: Hrithik Kumar Verma <vermahrithik812@gmail.com> Date: Mon Aug 23 17:35:37 2021 +0530 Added text files for kml, mscolab, wms, and views tutorials and fixed typos in tutorials.rst file commit c8b662b Merge: ee98974 3937b0a Author: ReimarBauer <rb.proj@gmail.com> Date: Mon Aug 23 07:41:44 2021 +0200 Merge pull request #1166 from risehr/documentation Created the tutorials.rst file commit 3937b0a Author: Hrithik Kumar Verma <vermahrithik812@gmail.com> Date: Mon Aug 23 02:32:17 2021 +0530 Fixed typos in performance settings text file commit 156fa36 Author: Hrithik Kumar Verma <vermahrithik812@gmail.com> Date: Mon Aug 23 02:22:41 2021 +0530 Added performance settings text file in tutorials/textfiles commit 6acc89e Author: Hrithik Kumar Verma <vermahrithik812@gmail.com> Date: Mon Aug 23 01:49:05 2021 +0530 Fixed typos in text files commit f681c0f Author: Hrithik Kumar Verma <vermahrithik812@gmail.com> Date: Mon Aug 23 01:18:54 2021 +0530 Updated tutorials.rst file and added some text files commit 0417b04 Author: Hrithik Kumar Verma <vermahrithik812@gmail.com> Date: Mon Aug 23 00:29:08 2021 +0530 Created the tutorials.rst file commit ee98974 Author: Hrithik Kumar Verma <54763705+risehr@users.noreply.github.com> Date: Sat Aug 21 13:59:43 2021 +0530 Mscolab tutorial, TTS feature for audios (#1162) * mscolab tutorial created * Created mscolab tutorial and added text to audio conversion feature for audio of the tutorial videos. Also updated tutorials.txt requirement file * Made some minor code improvements and rectified spelling mistakes * Made audio.py more customizable in terms of which translation and speech conversion APIs are to be used and also updated tutorials.txt requirement file * Removed the unnecessary comments commit df9aa18 Author: Hrithik Kumar Verma <54763705+risehr@users.noreply.github.com> Date: Tue Aug 17 14:11:38 2021 +0530 KML overlay, Hexagon Control, Performance settings tutorial completed (#1144) * Kml, hexagon control, and performance settings tutorial completed * Improved the screenrecorder class fixing some bugs, improved restricted size recording of windows * Minor changes in screen recorder class * made small changes in the header files of scipt and other minor changes in hexagon tutorial * Made the code more efficient by small changes in hexagon control tutorial commit bd3f251 Author: Hrithik Kumar Verma <54763705+risehr@users.noreply.github.com> Date: Mon Aug 9 18:55:26 2021 +0530 Remote Sensing and Satellite Track Tutorial (#1136) * Tutorial for remote sensing and satellite track and flexible/changeable screen recording area * Enabled FailSafe from screenrecorder.py file commit 5f70c3a Merge: 9170617 769b98a Author: ReimarBauer <rb.proj@gmail.com> Date: Fri Aug 6 16:58:51 2021 +0200 Merge pull request #1140 from Open-MSS/merged_develop_to_GSOC2021-HrithikKumarVerma Merged develop to gsoc2021 hrithik kumar verma commit 769b98a Author: ReimarBauer <rb.proj@gmail.com> Date: Fri Aug 6 16:25:42 2021 +0200 merge mistake fixed commit 7fd3765 Merge: 9170617 492482f Author: ReimarBauer <rb.proj@gmail.com> Date: Fri Aug 6 16:16:53 2021 +0200 Merge branch 'develop' into GSOC2021-HrithikKumarVerma commit 9170617 Merge: 6ab5a9d 36834c2 Author: ReimarBauer <rb.proj@gmail.com> Date: Wed Aug 4 09:28:13 2021 +0200 Merge pull request #1104 from risehr/views_tutorial [Completed] Automated tutorial for how to create a project in MSS using all the views. commit 36834c2 Author: Hrithik Kumar Verma <vermahrithik812@gmail.com> Date: Sun Aug 1 00:54:27 2021 +0530 Rectified some small mistakes such as remove extra space and unnecessary comments commit 41e83e1 Author: Hrithik Kumar Verma <vermahrithik812@gmail.com> Date: Sat Jul 31 02:51:43 2021 +0530 Made tutorial_views.py script to work for linux smoothly commit 0fee992 Author: Hrithik Kumar Verma <vermahrithik812@gmail.com> Date: Wed Jul 28 16:09:08 2021 +0530 Automated tutorial for how to create a project in MSS using all the views commit 6ab5a9d Author: Hrithik Kumar Verma <54763705+risehr@users.noreply.github.com> Date: Sun Jul 18 10:57:40 2021 +0530 Wms tutorial (#1083) * Made cursor visible and finished wms automated tutorial * flake8 corrections * Improved code for use in Linux systems.(It was working well in other systems) * Changed header file for the python scripts in mss/tutorials/* commit 3bb422c Merge: 2eda795 84ef56d Author: ReimarBauer <rb.proj@gmail.com> Date: Wed Jul 7 12:02:14 2021 +0200 Merge pull request #1074 from risehr/waypoints_tutorial Waypoints Tutorial : Working on Linux system now. commit 84ef56d Author: Hrithik Kumar Verma <vermahrithik812@gmail.com> Date: Mon Jul 5 21:08:40 2021 +0530 Rectified logical error in if statement; improved code to run both on linux and windows system efficiently commit 89d1417 Author: Hrithik Kumar Verma <vermahrithik812@gmail.com> Date: Mon Jul 5 18:45:50 2021 +0530 Modified waypoints tutorial to make it run smoothly on linux systems commit 2eda795 Author: Hrithik Kumar Verma <54763705+risehr@users.noreply.github.com> Date: Fri Jul 2 14:24:53 2021 +0530 Completed the waypoints tutorial and resolved the screen recording problems of being played too fast (#1067) * Allow specification of file for linear defaultstyle (#1028) * Allow specification of file for default * Simplify if condition * Increase coverage (#1020) * Add wms_control tests * Add more mscolab tests * Add mpl_qtwidget coverage * Add mss_pyui coverage * Add transparency, noframe and xml checks * Add more wms tests * Test import with plugins * Add linearview tests * Add more multilayering tests * Revert to old testing.yml * Leave no dangling windows * Remove todo, move ConnectionError to bottom Co-authored-by: ReimarBauer <rb.proj@gmail.com> * Migrate existing thermodynamic functions to metpy functions (#1009) * removed functions from thermolib.py functions to be replaced by metpy were removed * fixed: flake8 * fixed: flake8 * migrated to metpy functions Co-Authored-By: J. Ungermann <28449201+joernu76@users.noreply.github.com> * Fixed: flake8 * Fixed: flake8 * Fixed tests * Fixed: flake8 * Fixed: failing tests * Ficed: tests * Units discarded upon returning results Co-Authored-By: J. Ungermann <28449201+joernu76@users.noreply.github.com> * `omega_to_w` migrated to metpy Co-authored-by: ReimarBauer <rb.proj@gmail.com> Co-authored-by: J. Ungermann <28449201+joernu76@users.noreply.github.com> * updated documentation (#1008) * updated documentation * improved install/update procedure Co-authored-by: Reimar Bauer <rb.proj@gmail.com> * Fixed: #999 (#1010) * .format replaced with f" string * updated copyright year * fixes #1014 (#1015) * Remove Qt imports (#1019) * Fixes #1014 changing http to https (#1017) Co-authored-by: ReimarBauer <rb.proj@gmail.com> * Linear view mscolab bug (#1021) * fixed tableview not opening bug; added test * added raising of mscolab window after closing view * preparation of v4.0.1 (#1023) * preparation of v4.0.1 * updated install instruction Co-authored-by: J. Ungermann <j.ungermann@fz-juelich.de> * Fix pyproj 3.1.0 error (#1033) * Made a screen recorder and automated tutorial for demonstrating use of waypoints * Renamed tut pictures to just pictures and moved the tutorials.txt to requirements.d * Minor bug fixes. (#1054) * Return proper unit for eq. potential temperature (degC->K) * Do not assume units of pressure levels for several old plotting styles. * Fix values of geopotential altitude in demodata * issue #719 solved (#729) * issue #719 solved * updated development.rst * updated development.rst Co-authored-by: ReimarBauer <rb.proj@gmail.com> * Select newest init-time and carry over multilayering (#1047) Co-authored-by: J. Ungermann <j.ungermann@fz-juelich.de> * Fix some issues with elevation caching and model level dimensions. (#1061) Fix #1066 * Added missing filename key. (#1062) See #1066 * Waypoints tutorial completed * Just changed the sleep timings of the code to make it more efficient : tutorial_waypoints.py * Added the updated tutorials.txt in requirements.d Co-authored-by: May <baermay98@gmail.com> Co-authored-by: ReimarBauer <rb.proj@gmail.com> Co-authored-by: Jatin Jain <72596619+Jatin2020-24@users.noreply.github.com> Co-authored-by: J. Ungermann <28449201+joernu76@users.noreply.github.com> Co-authored-by: open-mss-build <77272604+open-mss-build@users.noreply.github.com> Co-authored-by: Aryan Gupta <42470695+withoutwaxaryan@users.noreply.github.com> Co-authored-by: Aravind Murali <aravindmurali711@gmail.com> Co-authored-by: J. Ungermann <j.ungermann@fz-juelich.de> Co-authored-by: Archishman Sengupta <71402528+ArchishmanSengupta@users.noreply.github.com> commit fca444a Author: Hrithik Kumar Verma <54763705+risehr@users.noreply.github.com> Date: Thu Jul 1 14:49:02 2021 +0530 Syncing my GSOC branch with develop (#1066) * Allow specification of file for linear defaultstyle (#1028) * Allow specification of file for default * Simplify if condition * Increase coverage (#1020) * Add wms_control tests * Add more mscolab tests * Add mpl_qtwidget coverage * Add mss_pyui coverage * Add transparency, noframe and xml checks * Add more wms tests * Test import with plugins * Add linearview tests * Add more multilayering tests * Revert to old testing.yml * Leave no dangling windows * Remove todo, move ConnectionError to bottom Co-authored-by: ReimarBauer <rb.proj@gmail.com> * Migrate existing thermodynamic functions to metpy functions (#1009) * removed functions from thermolib.py functions to be replaced by metpy were removed * fixed: flake8 * fixed: flake8 * migrated to metpy functions Co-Authored-By: J. Ungermann <28449201+joernu76@users.noreply.github.com> * Fixed: flake8 * Fixed: flake8 * Fixed tests * Fixed: flake8 * Fixed: failing tests * Ficed: tests * Units discarded upon returning results Co-Authored-By: J. Ungermann <28449201+joernu76@users.noreply.github.com> * `omega_to_w` migrated to metpy Co-authored-by: ReimarBauer <rb.proj@gmail.com> Co-authored-by: J. Ungermann <28449201+joernu76@users.noreply.github.com> * updated documentation (#1008) * updated documentation * improved install/update procedure Co-authored-by: Reimar Bauer <rb.proj@gmail.com> * Fixed: #999 (#1010) * .format replaced with f" string * updated copyright year * fixes #1014 (#1015) * Remove Qt imports (#1019) * Fixes #1014 changing http to https (#1017) Co-authored-by: ReimarBauer <rb.proj@gmail.com> * Linear view mscolab bug (#1021) * fixed tableview not opening bug; added test * added raising of mscolab window after closing view * preparation of v4.0.1 (#1023) * preparation of v4.0.1 * updated install instruction Co-authored-by: J. Ungermann <j.ungermann@fz-juelich.de> * Fix pyproj 3.1.0 error (#1033) * Minor bug fixes. (#1054) * Return proper unit for eq. potential temperature (degC->K) * Do not assume units of pressure levels for several old plotting styles. * Fix values of geopotential altitude in demodata * issue #719 solved (#729) * issue #719 solved * updated development.rst * updated development.rst Co-authored-by: ReimarBauer <rb.proj@gmail.com> * Select newest init-time and carry over multilayering (#1047) Co-authored-by: J. Ungermann <j.ungermann@fz-juelich.de> * Fix some issues with elevation caching and model level dimensions. (#1061) Fix #1066 * Added missing filename key. (#1062) See #1066 Co-authored-by: May <baermay98@gmail.com> Co-authored-by: ReimarBauer <rb.proj@gmail.com> Co-authored-by: Jatin Jain <72596619+Jatin2020-24@users.noreply.github.com> Co-authored-by: J. Ungermann <28449201+joernu76@users.noreply.github.com> Co-authored-by: open-mss-build <77272604+open-mss-build@users.noreply.github.com> Co-authored-by: Aryan Gupta <42470695+withoutwaxaryan@users.noreply.github.com> Co-authored-by: Aravind Murali <aravindmurali711@gmail.com> Co-authored-by: J. Ungermann <j.ungermann@fz-juelich.de> Co-authored-by: Archishman Sengupta <71402528+ArchishmanSengupta@users.noreply.github.com>

risehr added 2 commits July 28, 2021 16:09

Automated tutorial for how to create a project in MSS using all the v…

0fee992

…iews

Made tutorial_views.py script to work for linux smoothly

41e83e1

ReimarBauer requested changes Jul 31, 2021

View reviewed changes

Rectified some small mistakes such as remove extra space and unnecess…

36834c2

…ary comments

ReimarBauer self-requested a review August 4, 2021 07:27

ReimarBauer approved these changes Aug 4, 2021

View reviewed changes

ReimarBauer merged commit 9170617 into Open-MSS:GSOC2021-HrithikKumarVerma Aug 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Completed] Automated tutorial for how to create a project in MSS using all the views. #1104

[Completed] Automated tutorial for how to create a project in MSS using all the views. #1104

risehr commented Jul 31, 2021

Marilyth commented Jul 31, 2021

risehr commented Jul 31, 2021

ReimarBauer left a comment

ReimarBauer Jul 31, 2021

risehr Jul 31, 2021 •

edited

Loading

ReimarBauer Jul 31, 2021

ReimarBauer Jul 31, 2021

risehr Jul 31, 2021

ReimarBauer Jul 31, 2021

risehr Jul 31, 2021

ReimarBauer Jul 31, 2021

risehr Jul 31, 2021

ReimarBauer Jul 31, 2021

risehr Jul 31, 2021

ReimarBauer Jul 31, 2021

ReimarBauer Jul 31, 2021

risehr Jul 31, 2021

risehr commented Jul 31, 2021

ReimarBauer commented Jul 31, 2021

risehr commented Jul 31, 2021

ReimarBauer left a comment

[Completed] Automated tutorial for how to create a project in MSS using all the views. #1104

[Completed] Automated tutorial for how to create a project in MSS using all the views. #1104

Conversation

risehr commented Jul 31, 2021

Marilyth commented Jul 31, 2021

risehr commented Jul 31, 2021

ReimarBauer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

risehr Jul 31, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

risehr commented Jul 31, 2021

ReimarBauer commented Jul 31, 2021

risehr commented Jul 31, 2021

ReimarBauer left a comment

Choose a reason for hiding this comment

risehr Jul 31, 2021 •

edited

Loading