Refactor plotting of views #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joernu76
reviewed
Sep 4, 2022
mslib/msui/mpl_qtwidget.py
Outdated
|
|
||
| # Setup the plot. | ||
| self.update_vertical_extent_from_settings(init=True) | ||
|
|
||
| self.numlabels = numlabels | ||
| self.ax2 = self.ax.twinx() | ||
| self.ax.patch.set_facecolor("None") | ||
| self.ax2 = self.myfig.ax.twinx() |
There was a problem hiding this comment.
shouldn't the ax2 be part of the MySideViewFigure class?
There was a problem hiding this comment.
Indeed, you have added it to the correct class already. This must be removed.
swsrkty
force-pushed
the
Refactor-plotting-of-views
branch
from
2061b3d
to
78795bb
Compare
joernu76
force-pushed
the
Refactor-plotting-of-views
branch
from
8d7e78d
to
7bd73af
Compare
joernu76
pushed a commit
that referenced
this pull request
Nov 21, 2022
* Refactoring Side View * Fixing blank line * Fixing errors in plotting Side View and refactoring Linear View * Empty-Commit * Empty-Commit * Testing Top view in plot module * Testing Top View in plot module to use MyTopViewFigure class * Using getBBOX() * Using get_plot_size_in_px() * Testing Side view and Linear view in plot module * Adding tight layout for side view CLI script and documentation (#1598) * CLI script and documentation * Updating plot module * Adding template for plot module * Fixes in documentation and adding template for plot module * Fixing error in template of plot module * Adding testing for mssautoplot * Adding template and fixing errors * Fixing errors in tests * Fixing errors in mssautoplot and updating mpl_pathinteractor module * Removing test_mssautoplot.py * Fixing flake8 errors
joernu76
pushed a commit
that referenced
this pull request
Nov 21, 2022
* Refactoring Side View * Fixing blank line * Fixing errors in plotting Side View and refactoring Linear View * Empty-Commit * Empty-Commit * Testing Top view in plot module * Testing Top View in plot module to use MyTopViewFigure class * Using getBBOX() * Using get_plot_size_in_px() * Testing Side view and Linear view in plot module * Adding tight layout for side view CLI script and documentation (#1598) * CLI script and documentation * Updating plot module * Adding template for plot module * Fixes in documentation and adding template for plot module * Fixing error in template of plot module * Adding testing for mssautoplot * Adding template and fixing errors * Fixing errors in tests * Fixing errors in mssautoplot and updating mpl_pathinteractor module * Removing test_mssautoplot.py * Fixing flake8 errors Work by Joern Ungermann: * fix flake8 and minor bugs Co-authored-by: Joern Ungermann <j.ungermann@fz-juelich.de>
joernu76
pushed a commit
that referenced
this pull request
Nov 21, 2022
* Refactoring Side View * Fixing blank line * Fixing errors in plotting Side View and refactoring Linear View * Empty-Commit * Empty-Commit * Testing Top view in plot module * Testing Top View in plot module to use MyTopViewFigure class * Using getBBOX() * Using get_plot_size_in_px() * Testing Side view and Linear view in plot module * Adding tight layout for side view CLI script and documentation (#1598) * CLI script and documentation * Updating plot module * Adding template for plot module * Fixes in documentation and adding template for plot module * Fixing error in template of plot module * Adding testing for mssautoplot * Adding template and fixing errors * Fixing errors in tests * Fixing errors in mssautoplot and updating mpl_pathinteractor module * Removing test_mssautoplot.py * Fixing flake8 errors Work by Joern Ungermann: * fix flake8 and minor bugs Co-authored-by: Joern Ungermann <j.ungermann@fz-juelich.de>
joernu76
pushed a commit
that referenced
this pull request
Nov 21, 2022
* Refactoring Side View * Fixing blank line * Fixing errors in plotting Side View and refactoring Linear View * Empty-Commit * Empty-Commit * Testing Top view in plot module * Testing Top View in plot module to use MyTopViewFigure class * Using getBBOX() * Using get_plot_size_in_px() * Testing Side view and Linear view in plot module * Adding tight layout for side view CLI script and documentation (#1598) * CLI script and documentation * Updating plot module * Adding template for plot module * Fixes in documentation and adding template for plot module * Fixing error in template of plot module * Adding testing for mssautoplot * Adding template and fixing errors * Fixing errors in tests * Fixing errors in mssautoplot and updating mpl_pathinteractor module * Removing test_mssautoplot.py * Fixing flake8 errors Work by Joern Ungermann: * fix flake8 and minor bugs Co-authored-by: Joern Ungermann <j.ungermann@fz-juelich.de>
joernu76
pushed a commit
that referenced
this pull request
Nov 21, 2022
* Refactoring Side View * Fixing blank line * Fixing errors in plotting Side View and refactoring Linear View * Empty-Commit * Empty-Commit * Testing Top view in plot module * Testing Top View in plot module to use MyTopViewFigure class * Using getBBOX() * Using get_plot_size_in_px() * Testing Side view and Linear view in plot module * Adding tight layout for side view CLI script and documentation (#1598) * CLI script and documentation * Updating plot module * Adding template for plot module * Fixes in documentation and adding template for plot module * Fixing error in template of plot module * Adding testing for mssautoplot * Adding template and fixing errors * Fixing errors in tests * Fixing errors in mssautoplot and updating mpl_pathinteractor module * Removing test_mssautoplot.py * Fixing flake8 errors Work by Joern Ungermann: * fix flake8 and minor bugs Co-authored-by: Joern Ungermann <j.ungermann@fz-juelich.de>
joernu76
pushed a commit
that referenced
this pull request
Nov 21, 2022
* Refactoring Side View * Fixing blank line * Fixing errors in plotting Side View and refactoring Linear View * Empty-Commit * Empty-Commit * Testing Top view in plot module * Testing Top View in plot module to use MyTopViewFigure class * Using getBBOX() * Using get_plot_size_in_px() * Testing Side view and Linear view in plot module * Adding tight layout for side view CLI script and documentation (#1598) * CLI script and documentation * Updating plot module * Adding template for plot module * Fixes in documentation and adding template for plot module * Fixing error in template of plot module * Adding testing for mssautoplot * Adding template and fixing errors * Fixing errors in tests * Fixing errors in mssautoplot and updating mpl_pathinteractor module * Removing test_mssautoplot.py * Fixing flake8 errors Work by Joern Ungermann: * fix flake8 and minor bugs Co-authored-by: Joern Ungermann <j.ungermann@fz-juelich.de>
joernu76
pushed a commit
that referenced
this pull request
Nov 22, 2022
* Refactoring Side View * Fixing blank line * Fixing errors in plotting Side View and refactoring Linear View * Empty-Commit * Empty-Commit * Testing Top view in plot module * Testing Top View in plot module to use MyTopViewFigure class * Using getBBOX() * Using get_plot_size_in_px() * Testing Side view and Linear view in plot module * Adding tight layout for side view CLI script and documentation (#1598) * CLI script and documentation * Updating plot module * Adding template for plot module * Fixes in documentation and adding template for plot module * Fixing error in template of plot module * Adding testing for mssautoplot * Adding template and fixing errors * Fixing errors in tests * Fixing errors in mssautoplot and updating mpl_pathinteractor module * Removing test_mssautoplot.py * Fixing flake8 errors Work by Joern Ungermann: * fix flake8 and minor bugs Co-authored-by: Joern Ungermann <j.ungermann@fz-juelich.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.