GUI FOR AUTOMATED PLOTTING 2- update the GUI #2464

Preetam-Das26 · 2024-08-15T21:18:13Z

Purpose of PR?:

Fixes #

Does this PR introduce a breaking change?

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Does this PR results in some Documentation changes?
If yes, include the list of Documentation changes

Checklist:

Bug fix. Fixes #
New feature (Non-API breaking changes that adds functionality)
PR Title follows the convention of <type>: <subject>
Commit has unit tests

ReimarBauer · 2024-08-16T09:19:18Z

On an operation the filename column is used (ok), but an operation has no extension

I start with AIRS(ECMWF) and click then Add - something of the data is changed

How and What?

ReimarBauer · 2024-08-16T09:24:17Z

On an operation the filename column is used (ok), but an operation has no extension

I start with AIRS(ECMWF) and click then Add - something of the data is changed

How and What?

lookslike I had a transmission failure.

ReimarBauer · 2024-08-16T09:39:51Z

when I resize it also or also change the width of the column the left treewidget keeps a lot of space. Could you enable that both take only the space they needs?

ReimarBauer · 2024-08-16T09:48:01Z

While the UI in the Multilayer selector can use direct the cached images from the defined dir in the configuration. For me it is tmp/msui_wms_cache the autoplot does on each load the capabilities. This needs usually only done once. This gives a delay. Please look if you can skip this "get capability" request.

ReimarBauer · 2024-08-16T10:04:35Z

When storing such a configuration one has to add .json. There is suppot by qt for this https://doc.qt.io/qt-6/qfiledialog.html#defaultSuffix-prop

reloading from file works too. :)

Download Plots crashes

default
Style 'autolog' not found for layer 'CLaMS_PL.mole_fraction_of_CH3Br_in_air_pl'.
log  | 
Style 'autolog' not found for layer 'CLaMS_PL.mole_fraction_of_CH3Br_in_air_pl'.
Usage: autoplot_gui [OPTIONS]
Try 'autoplot_gui --help' for help.

Error: Invalid value for '--intv': '' is not a valid integer.
Speicherzugriffsfehler

ReimarBauer · 2024-08-16T10:04:49Z

Restoring the level is not implemented?

ReimarBauer · 2024-08-19T08:48:56Z

The recent change creates an error for me

…get from closing after downloading the plots

…logs added

ReimarBauer

please can you undo your merge of develop into the PR?

This does not reflect the state of the work during GSOC
We have to do the following order, squash merge the PR to your Gsoc branch.
merge the gsoc branch to develop.

You can ignore the failing tests, because we know the reason.

ReimarBauer · 2024-09-30T18:44:45Z

with temporary applying https://github.com/Open-MSS/MSS/pull/2537/files#diff-2ba1f11e715e19bf607aa39b8541650e9cc7062cea55288accced904af34d3ca

542 passed, 13 skipped, 32 warnings in 434.61s (0:07:14)

ReimarBauer · 2024-09-30T19:00:24Z

mslib/msui/msui_mainwindow.py

@@ -51,7 +51,7 @@
 from mslib.msui.icons import icons, python_powered
 from mslib.utils.qt import get_open_filenames, get_save_filename, show_popup
 from mslib.utils.config import read_config_file, config_loader
-from PyQt5 import QtGui, QtCore, QtWidgets
+from PyQt5 import QtGui, QtCore, QtWidgets, QtTest
 from matplotlib.backends.backend_qt5agg import FigureCanvasQTAgg as FigureCanvas


that is an interesting usecase, we have to lookup afterwards

ReimarBauer · 2024-09-30T19:03:03Z

mslib/msui/linearview.py

@@ -83,6 +83,9 @@ class MSUILinearViewWindow(MSUIMplViewWindow, ui.Ui_LinearWindow):

    refresh_signal_send = QtCore.pyqtSignal()
    refresh_signal_emit = QtCore.pyqtSignal()
+    item_selected = QtCore.pyqtSignal(str, str, str, str)
+    vtime_vals = QtCore.pyqtSignal([list])


This needs a review after the merge how the list evolves

ReimarBauer · 2024-09-30T19:04:01Z

docs/Autoplot_dock_widget.rst

@@ -0,0 +1,97 @@
+GUI FOR AUTOMATED PLOTTING


The filename needs to be lowercase later

ReimarBauer · 2024-09-30T19:05:13Z

mslib/msui/autoplot_dockwidget.py

 from mslib.msui.qt5.ui_mss_autoplot import Ui_AutoplotDockWidget
 from mslib.msui import constants as const
+from datetime import datetime



this needs to be reordered later

ReimarBauer · 2024-09-30T19:06:00Z

mslib/msui/autoplot_dockwidget.py

+    autoplot_treewidget_item_selected = QtCore.pyqtSignal(str, str)
+    update_op_flight_treewidget = QtCore.pyqtSignal(str, str)
+
+    def __init__(self, parent=None, parent2=None, view=None, config_settings=None):


the parent names can become more meaningful

ReimarBauer · 2024-09-30T19:13:09Z

mslib/msui/sideview.py

@@ -256,6 +256,9 @@ class MSUISideViewWindow(MSUIMplViewWindow, ui.Ui_SideViewWindow):

    refresh_signal_send = QtCore.pyqtSignal()
    refresh_signal_emit = QtCore.pyqtSignal()
+    item_selected = QtCore.pyqtSignal(str, str, str, str)
+    vtime_vals = QtCore.pyqtSignal([list])


we have to check later how the list evolves

ReimarBauer · 2024-09-30T19:13:57Z

mslib/msui/topview.py

@@ -190,6 +190,9 @@ class MSUITopViewWindow(MSUIMplViewWindow, ui.Ui_TopViewWindow):
    sections_changed = QtCore.pyqtSignal(str)
    refresh_signal_emit = QtCore.pyqtSignal()
    refresh_signal_send = QtCore.pyqtSignal()
+    item_selected = QtCore.pyqtSignal(str, str, str, str)
+    itemSecs_selected = QtCore.pyqtSignal(str)
+    vtime_vals = QtCore.pyqtSignal([list])


we have to check later how the list evolves

ReimarBauer · 2024-09-30T19:14:51Z

mslib/msui/topview.py

@@ -426,10 +455,11 @@ def level_val_changed(self, strr):

    @QtCore.pyqtSlot()
    def styles_val_changed(self, strr):
-        if strr is None:
+        if strr is None or not str(strr).strip():


this can become a better name later

ReimarBauer · 2024-09-30T19:15:35Z

mslib/msui/wms_control.py

@@ -410,6 +410,7 @@ class WMSControlWidget(QtWidgets.QWidget, ui.Ui_WMSDockWidget):
    styles_changed = QtCore.pyqtSignal(str)
    itime_changed = QtCore.pyqtSignal(str)
    vtime_changed = QtCore.pyqtSignal(str)
+    vtime_data = QtCore.pyqtSignal([list])


we have to check later how the list evolves

ReimarBauer · 2024-09-30T19:16:21Z

mslib/msui/wms_control.py

+                # Iterate over the children of the top-level item
+                for i in range(top_item.childCount()):
+                    child_item = top_item.child(i)
+


review for empty formatting lines later

ReimarBauer · 2024-09-30T19:18:21Z

mslib/msui/wms_control.py

+                        self.current_sel_layer = child_item
+
+        if not self.current_sel_layer:
+            print(f"Layer '{layer_name}' not found.")


when that is important only a popup reaches the user, needs to become checked later

ReimarBauer · 2024-09-30T19:25:07Z

mslib/utils/mssautoplot.py

+
+
+def get_xml_data(mscolab_server_url, token, op_id):
+    if verify_user_token(mscolab_server_url, token):


this needs a change after the merge, because in develop this verify_user_token was refactored.

ReimarBauer · 2024-09-30T19:26:00Z

mslib/utils/mssautoplot.py

+
+def get_op_id(token, mscolab_server_url, curr_op):
+    logging.debug('get_recent_op_id')
+    if verify_user_token(mscolab_server_url, token):


ReimarBauer · 2024-09-30T19:31:15Z

mslib/utils/mssautoplot.py



 if __name__ == '__main__':
-    main()
+    cli_tool()


this needs an additional change in https://github.com/Open-MSS/MSS/blob/develop/setup.py#L39

I am not convinced by the new name.

ReimarBauer · 2024-09-30T19:37:18Z

mslib/utils/mssautoplot.py

+import requests
+from urllib.parse import urljoin
+import json
+from PyQt5.QtCore import Qt



later imports should be sorted later, https://peps.python.org/pep-0008/#imports

Imports should be grouped in the following order:

Standard library imports.
Related third party imports.
Local application/library specific imports.

ReimarBauer

there is a crash from sideview when I try to download plots to be solved after this got merged

Python 3.11.6 | packaged by conda-forge | (main, Oct  3 2023, 10:40:35) [GCC 12.3.0]

Please report bugs in MSS to https://github.com/Open-MSS/MSS

Information about the fatal error:

Traceback (most recent call last):
  File "/home/reimar/PycharmProjects/2024/Preetam-Das26/MSS/mslib/msui/autoplot_dockwidget.py", line 147, in <lambda>
    self.downloadPushButton.clicked.connect(lambda: self.download_plots_cli(config_settings))
                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/reimar/PycharmProjects/2024/Preetam-Das26/MSS/mslib/msui/autoplot_dockwidget.py", line 199, in download_plots_cli
    ctx.invoke(cli_tool, **args)
  File "/home/reimar/Miniforge/envs/mssdev/lib/python3.11/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/reimar/Miniforge/envs/mssdev/lib/python3.11/site-packages/click/decorators.py", line 33, in new_func
    return f(get_current_context(), *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/reimar/PycharmProjects/2024/Preetam-Das26/MSS/mslib/utils/mssautoplot.py", line 470, in cli_tool
    side_view = SideViewPlotting(cpath, mss_url, mss_password, mss_auth)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/reimar/PycharmProjects/2024/Preetam-Das26/MSS/mslib/utils/mssautoplot.py", line 281, in __init__
    super(SideViewPlotting, self).__init__(cpath)
  File "/home/reimar/PycharmProjects/2024/Preetam-Das26/MSS/mslib/utils/mssautoplot.py", line 176, in __init__
    self.read_operation(flight, username, password, mscolab_server_url)
  File "/home/reimar/PycharmProjects/2024/Preetam-Das26/MSS/mslib/utils/mssautoplot.py", line 198, in read_operation
    self.wps, self.wp_model_data = load_from_operation(
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: cannot unpack non-iterable NoneType object

ReimarBauer

There is some work to do, which should be done in more than one PR.

This is a good step further and it is a nice functionality

update msui mainwindow based on left treewidget, download from operations implemented completely and prcess dialogs added, update msui mainwindow based on left treewidget,

COMMIT 1:update the dock widget

0fcdf12

COMMIT 2 : Download using CLI updated

9c978ce

Preetam-Das26 added 20 commits August 19, 2024 19:53

COMMIT : connect to CLI,update maps,level combo box

7348e76

COMMIT 5:improve the update feature,remove print statements

373201c

COMMIT : update left tree widget

c3a0609

left tree widget update,level changed

97950d3

COMMIT download dialog added, no extension for operations

6763046

COMMIT download cli,stime,etime update

8cac86a

COMMIT return statement added

2faade1

COMMIT resolved bugs

1060c5a

new changes

5a83dad

COMMIT fixed bugs

b415bfe

COMMIT update msui mainwindow based on left treewidget

6023d29

COMMIT updates

32a6a17

COMMIT operations added to downloads and made changes to stop the wid…

14ed6a8

…get from closing after downloading the plots

COMMIT download from operations implemented completely and prcess dia…

5fa1eaa

…logs added

COMMIT

293bf0f

COMMIT resolved the error regarding the cli tool

8e2187f

COMMIT resolved the naming issue

19eb705

COMMMIT formatting improved

7d53bb3

COMMMIT formatting improved

ac9006f

COMMMIT pssing tests

38d0049

Preetam-Das26 marked this pull request as ready for review September 19, 2024 06:14

Preetam-Das26 force-pushed the gsoc_psd branch from e8c1f49 to 22aa853 Compare September 26, 2024 10:31

ReimarBauer requested changes Sep 30, 2024

View reviewed changes

Preetam-Das26 added 5 commits September 30, 2024 22:11

COMMIT files added

9ca9eaf

COMMIT bug fixes

c2df763

COMMIT

b68fe4c

removed unwanted print statement

27a0f57

COMMIT warning

cfffdbc

Preetam-Das26 force-pushed the gsoc_psd branch from a4d2e1a to cfffdbc Compare September 30, 2024 16:45

Preetam-Das26 requested a review from ReimarBauer September 30, 2024 16:49

ReimarBauer reviewed Sep 30, 2024

View reviewed changes

docs/Autoplot_dock_widget.rst

@@ -0,0 +1,97 @@

GUI FOR AUTOMATED PLOTTING

Copy link

Member

ReimarBauer Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filename needs to be lowercase later

ReimarBauer reviewed Sep 30, 2024

View reviewed changes

ReimarBauer approved these changes Sep 30, 2024

View reviewed changes

ReimarBauer merged commit d9ce793 into Open-MSS:GSOC2024-PreetamSundarDas Sep 30, 2024
5 of 10 checks passed

Preetam-Das26 deleted the gsoc_psd branch October 1, 2024 05:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GUI FOR AUTOMATED PLOTTING 2- update the GUI #2464

GUI FOR AUTOMATED PLOTTING 2- update the GUI #2464

Preetam-Das26 commented Aug 15, 2024

ReimarBauer commented Aug 16, 2024

ReimarBauer commented Aug 16, 2024 •

edited

Loading

ReimarBauer commented Aug 16, 2024

ReimarBauer commented Aug 16, 2024

ReimarBauer commented Aug 16, 2024 •

edited

Loading

ReimarBauer commented Aug 16, 2024

ReimarBauer commented Aug 19, 2024

ReimarBauer left a comment •

edited

Loading

ReimarBauer commented Sep 30, 2024

ReimarBauer Sep 30, 2024

ReimarBauer Sep 30, 2024

ReimarBauer Sep 30, 2024

ReimarBauer Sep 30, 2024

ReimarBauer Sep 30, 2024

ReimarBauer Sep 30, 2024

ReimarBauer Sep 30, 2024

ReimarBauer Sep 30, 2024

ReimarBauer Sep 30, 2024

ReimarBauer Sep 30, 2024

ReimarBauer Sep 30, 2024

ReimarBauer Sep 30, 2024 •

edited

Loading

ReimarBauer Sep 30, 2024

ReimarBauer Sep 30, 2024

ReimarBauer Sep 30, 2024 •

edited

Loading

ReimarBauer left a comment

ReimarBauer left a comment



		def get_xml_data(mscolab_server_url, token, op_id):
		if verify_user_token(mscolab_server_url, token):

GUI FOR AUTOMATED PLOTTING 2- update the GUI #2464

GUI FOR AUTOMATED PLOTTING 2- update the GUI #2464

Conversation

Preetam-Das26 commented Aug 15, 2024

ReimarBauer commented Aug 16, 2024

ReimarBauer commented Aug 16, 2024 • edited Loading

ReimarBauer commented Aug 16, 2024

ReimarBauer commented Aug 16, 2024

ReimarBauer commented Aug 16, 2024 • edited Loading

ReimarBauer commented Aug 16, 2024

ReimarBauer commented Aug 19, 2024

ReimarBauer left a comment • edited Loading

Choose a reason for hiding this comment

ReimarBauer commented Sep 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ReimarBauer Sep 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ReimarBauer Sep 30, 2024 • edited Loading

Choose a reason for hiding this comment

ReimarBauer left a comment

Choose a reason for hiding this comment

ReimarBauer left a comment

Choose a reason for hiding this comment

ReimarBauer commented Aug 16, 2024 •

edited

Loading

ReimarBauer commented Aug 16, 2024 •

edited

Loading

ReimarBauer left a comment •

edited

Loading

ReimarBauer Sep 30, 2024 •

edited

Loading

ReimarBauer Sep 30, 2024 •

edited

Loading