Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorder imports in autoplot_dockwidget #2555

Conversation

Preetam-Das26
Copy link
Collaborator

Purpose of PR?:
reorder imports in autoplot_dockwidget
Fixes #

Does this PR introduce a breaking change?

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Does this PR results in some Documentation changes?
If yes, include the list of Documentation changes

Checklist:

  • Bug fix. Fixes #
  • New feature (Non-API breaking changes that adds functionality)
  • PR Title follows the convention of <type>: <subject>
  • Commit has unit tests

from PyQt5.QtWidgets import QWidget, QFileDialog, QTreeWidgetItem, QMessageBox
from PyQt5 import QtCore
import click
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this before the first from PyQt5 import then we have all from after each other. both are also not in the standardlib

Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one import has a name problem, because the cli_tool was renamed back to main.

mslib/msui/autoplot_dockwidget.py Outdated Show resolved Hide resolved
@ReimarBauer
Copy link
Member

maybe do this also for mslib.utils.mssautoplot, there e.g. requests needs to become separately installed is not in stdlib.

from datetime import datetime, timedelta
import io
import logging
import re
import os
import sys
import requests
from urllib.parse import urljoin
import json
from PyQt5.QtCore import Qt

@ReimarBauer ReimarBauer merged commit 26c90b7 into Open-MSS:GSOC2024-rebased-autoplot Oct 6, 2024
7 of 10 checks passed
@Preetam-Das26 Preetam-Das26 deleted the imports_reordering branch October 10, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants