Autoplot - Enable mssautoplot for side and linearviews #2563
Conversation
Preetam-Das26
changed the title
mslib/utils/mssautoplot.py
Outdated
| @@ -421,12 +433,16 @@ def draw(self, flight, section, vertical, filename, init_time, time, url, layer, | |||
|
|
|||
| class LinearViewPlotting(Plotting): | |||
| # ToDo Implement access of MSColab | |||
| def __init__(self, cpath): | |||
| def __init__(self, cpath, msc_url, msc_auth_password, msc_username, msc_password): | |||
| super(LinearViewPlotting, self).__init__(cpath) | |||
There was a problem hiding this comment.
comparing with class TopViewPlotting(Plotting):
We have there super(TopViewPlotting, self).__init__(cpath, msc_url, msc_auth_password, msc_username, msc_password) too.
Same question also for super(SideViewPlotting, self).__init__(cpath)
Is that required? If not please look if it is in TopViewPlotting required too or could be changed to a similiar.
There was a problem hiding this comment.
Yes that is required. Changes Done.
There was a problem hiding this comment.
In different to topview and linearview the sideview does not use the mscolab server, it looks for a filename new1 in that example. Please improve this.
UPDATE: I just recognized that in mssautoplot, in draw "linear" is not yet implemented. Work to implement linear should go in a different PR. Focus on get sideview with mscolab working as topview does.
…side_and_linearviews
ReimarBauer
merged commit a2e4f5e
into
Open-MSS:GSOC2024-rebased-autoplot
Purpose of PR?:
Enable mssautoplot for side and linearviews
Fixes #
Does this PR introduce a breaking change?
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Does this PR results in some Documentation changes?
If yes, include the list of Documentation changes
Checklist:
<type>: <subject>