Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a tmp dir does not need a 2nd random var #2604

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

ReimarBauer
Copy link
Member

Purpose of PR?:

Fixes #2536

@ReimarBauer ReimarBauer changed the title a tmp dir does not need a scnd random var a tmp dir does not need a 2nd random var Jan 24, 2025
@ReimarBauer ReimarBauer force-pushed the refactor_test_constants branch from d503b2b to 7d7b644 Compare January 27, 2025 14:08
Copy link
Collaborator

@matrss matrss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually blocked running the test suite in a non-git checkout of the source code (e.g. extracted source archive) as it wouldn't find a commit sha then. So it is good that it gets removed.

But some changes are missing:

  1. This was the only usage of the git module in tests/, so the development dependency on gitpython can be removed:
  2. The docs are outdated now:

    MSS/docs/development.rst

    Lines 228 to 229 in a3a98d8

    We have implemented demodata as data base for testing. On first call of pytest a set of demodata becomes stored
    in a /tmp/mss* folder. If you have installed gitpython a postfix of the revision head is added.

@ReimarBauer
Copy link
Member Author

  1. This was the only usage of the git module in tests/, so the development dependency on gitpython can be removed:

good catch, this should have been removed there already some time longer. The move to the meta.yaml was a copy.

@ReimarBauer ReimarBauer requested a review from matrss February 4, 2025 11:31
@matrss
Copy link
Collaborator

matrss commented Feb 4, 2025

All test jobs are failing now... I suspect that to only be indirectly triggered by the changes though, because the dependency change causes a new environment resolution. I have seen the same test failures in #2298, but thought it was something specific to that PR until now. I misremembered, I think.

@ReimarBauer
Copy link
Member Author

All test jobs are failing now... I suspect that to only be indirectly triggered by the changes though, because the dependency change causes a new environment resolution. I have seen the same test failures in #2298, but thought it was something specific to that PR until now. I misremembered, I think.

yeah, one timouts, 4 numpy related, #2616

@ReimarBauer ReimarBauer force-pushed the refactor_test_constants branch from 7db43f7 to 9c6428f Compare February 5, 2025 10:15
@ReimarBauer ReimarBauer merged commit 9d3312e into Open-MSS:develop Feb 10, 2025
10 of 11 checks passed
@ReimarBauer ReimarBauer deleted the refactor_test_constants branch February 10, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

review / refactor tests/constants.py
2 participants