-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a tmp dir does not need a 2nd random var #2604
a tmp dir does not need a 2nd random var #2604
Conversation
d503b2b
to
7d7b644
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually blocked running the test suite in a non-git checkout of the source code (e.g. extracted source archive) as it wouldn't find a commit sha then. So it is good that it gets removed.
But some changes are missing:
- This was the only usage of the git module in tests/, so the development dependency on gitpython can be removed:
MSS/requirements.d/development.txt
Line 15 in a3a98d8
gitpython - The docs are outdated now:
Lines 228 to 229 in a3a98d8
We have implemented demodata as data base for testing. On first call of pytest a set of demodata becomes stored in a /tmp/mss* folder. If you have installed gitpython a postfix of the revision head is added.
good catch, this should have been removed there already some time longer. The move to the meta.yaml was a copy. |
|
yeah, one timouts, 4 numpy related, #2616 |
7db43f7
to
9c6428f
Compare
Purpose of PR?:
Fixes #2536