-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an MSS updater #984
Add an MSS updater #984
Conversation
on windows we used
this was used by me recently also on linux. probably we could verify first which python version is available and not request a minor one. |
Your command works only if there is no mss preinstalled I think. Otherwise mamba will keep the old mss version and be happy with it.
where {version} is the latest one. Is there a reason to specify 3.9 instead of just telling mamba to match it to the newest mss @ReimarBauer ? |
The previous python=3.9 was some time ago a solution for a few windows installations. |
the replacement of an existing env is something which should be explained to the user. And I'm still not sure if we should do this automated. I'm also not sure if this scales, when a user has own plugins, libs additional installed in an mssenv. An other option is to guide the user through these steps for a backupped new installation. So it is half automated and we could also verify that it probably will be successful. |
I fully agree. I pursued the ability to create and replace the environment in case an update does not work, but I had to give up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Marilyth I do later a deeper review. I've seen already that it is centric to the UI user which is a good choice.
I would also like to have a command line feature, at least for the servers. That must not do everything like the gui but it should log or output on a command option that the version is outdated. If that is too much now we can postpone that.
Sure, I will detach the functions from the UI and bring the updater to the servers also. |
played a little with it, with some fake versions. Works pretty well :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very well done
* Updater Step 1 * Better workflow * Finish updater * Add tests * Add backups, use environment only as last resort * Mock Worker, test environment code * Make process more transparent and safe * Backup only at replacement, warn user on replacement * Warn the user even more in case of environment replacement * More tests * Remove environment replacement * Make restarter work on windows * Move updater to utils * Add command line update arguments Co-authored-by: ReimarBauer <rb.proj@gmail.com>
fixes #899
mamba/conda install mss={newest} python
is sufficientI have decided against the functionality to create and replace the current environment. It is an absolute nightmare especially on Windows and its permission system. Random crashes can ruin the environment etc.
Also it seems coverage does not capture QThreads, which is a bummer since the majority of the updater is running in the background.