Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VictorSP Set Not Accurate #38

Open
wvauclain opened this issue Mar 16, 2016 · 5 comments
Open

VictorSP Set Not Accurate #38

wvauclain opened this issue Mar 16, 2016 · 5 comments

Comments

@wvauclain
Copy link

Whenever I use a VictorSP, at least in sim, the motor controller gets set to what it needs to be minus 0.05, so if I were to simply access both of them in the registrar, on the sim RoboRIO their signal immediately drops to -0.05. You can sets them to -1 just fine, but the maximum signal strength a VictorSP can be set to is 0.94.

@LoadingPleaseWait
Copy link
Contributor

I can confirm that this bug is in Toast for me too.

@JaciBrunning
Copy link
Member

This is due to each Motor Controller having it's own PWM timings. What we do is we patch PWM, not the Motor Controller. We times this by a rough value to get approximately what each controller is running at within a reasonable margin of error. It's not exact, but it's the closest we can get without patching 'front-end classes'.

@wvauclain
Copy link
Author

So this means that the error is simply a problem with the simulator, and will not be present on the RoboRIO itself?

@JaciBrunning
Copy link
Member

Correct. Realistically, a difference that small would not cause an issue,
as it is too small for most motors / controllers

On Sat, 19 Mar 2016 07:04 Willv19 notifications@github.com wrote:

So this means that the error is simply a problem with the simulator, and
will not be present on the RoboRIO itself?


You are receiving this because you commented.

Reply to this email directly or view it on GitHub
#38 (comment)

@Samcfuchs
Copy link

Is this issue closed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants