-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atlassian/version 3.41.3 #140
Atlassian/version 3.41.3 #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AWildegger you very much, I have some comments can you please work on them
@@ -0,0 +1,20 @@ | |||
## Download Location | |||
|
|||
https://github.com/atlassian-api/atlassian-python-api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide here the concrete download link
|
||
## Comment | ||
|
||
Only the Python packages of the components have been curated, not the entire packages found in the download location. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case the same applies here as for altgraph, this is an inconsistency, which makes the analysis not usable because you have probably installed the package via "pip install" fetching the package from pypi but do you have a proof that this is exactly the same as the package specified in the download link?
To be honest and I am sorry but I cant accept such a potential source of inconsistent data.
I also did a
pipinstall atlassian-python-api==3.41.3
in order to verify that what is installed via pip is not the package available on GitHub, in the best case it is a subset and in the worst case it contains different files or different file content (i did not verify the file hashes).
FileCopyrightText: | ||
Copyright 2014 Mateusz Harasymczuk, Gonchik Tsymzhitov | ||
|
||
LicenseConcluded: LicenseRef-fossology-Apache-2.0-af5b3d00d6efa4c915c087dc57f6ae02 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As already commented in the altgraph PR I do not think that the text of the Apache-2.0 license is licensed under Apache-2.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add only the anaylsis for one package in a pull request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add only the anaylsis for one package in a pull request
|
||
##File | ||
|
||
FileName: site-packages_atlassian-with-distinfo.zip/site-packages_atlassian-with-distinfo/atlassian_python_api-3.41.3.dist-info/METADATA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file I did not find in the original apckage downloaded from GitHub. In the site-packages folder of my PC there I found it, it contains among other information:
Summary: Python Atlassian REST API Wrapper
Home-page: https://github.com/atlassian-api/atlassian-python-api
Download-URL: https://github.com/atlassian-api/atlassian-python-api
Author: Matt Harasymczuk
Author-email: matt@astrotech.io
Maintainer: Gonchik Tsymzhitov
Maintainer-email: gonchik.tsymzhitov@gmail.com
License: Apache License 2.0
These are the meta data of the package but not the license of this file in my opinion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file does not contain all the files of the package referenced in the README.
Furthermore it contains files which are not in the package referenced in the README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve in this file my comments in the disclosure file and tag value file, too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve in this file my comments in the disclosure file and tag value file, too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve in this file my comments in the disclosure file and tag value file, too
There is no progress anymore, I close it for now. |
Adds curation results for atlassian version 3.41.3.