Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter added to an inhibition/induction process should be GLOBAL #769

Closed
PavelBal opened this issue Oct 6, 2022 · 12 comments
Closed
Assignees

Comments

@PavelBal
Copy link
Member

PavelBal commented Oct 6, 2022

I created a new parameter in the Induction-Process container of a molecule in the Molecules-BB:

image

When I create a simulation with this building block, the parameter is not there:

image

@Yuri05 @msevestre Could you explain? Am I doing something wrong?

@msevestre
Copy link
Member

Am I doing something wrong?

YES.
..

but I am not sure what :)

@msevestre
Copy link
Member

can you attach a project so that I can reproduce?

@PavelBal
Copy link
Member Author

PavelBal commented Oct 6, 2022

MoBi_769_customParameterInInducionProcess.zip

Here is a more simple example. I have added a "CustomParameter" to "CYP3A4-Kajisaari 2005" process under "Rifampicin" molecule
image

But is does not appear in the simulation:

image

@StephanSchaller
Copy link
Member

And you are sure you are using this Building Block?
Can you expand the PSV BB and find the parameter there?

@PavelBal
Copy link
Member Author

PavelBal commented Oct 6, 2022

And you are sure you are using this Building Block?

Please! :D

Can you expand the PSV BB and find the parameter there?

No parameters from Induction/Inhibition processes or active transportrs are in the PSV BB.

@msevestre
Copy link
Member

I am looking at it now....

Mansplaning lol

@StephanSchaller
Copy link
Member

I am looking at it now....

Mansplaning lol

Sometimes the obvious is the solution ;-)

@msevestre
Copy link
Member

The issue I believe is that by default the parameter is created as a LOCAL parameter
image

(This is definitely a bug as Local parameter are probably ignored at this level)

If I change it to global, it works
image

@msevestre
Copy link
Member

I aam going to rename this issue to Parameter in process should be created as GLOBAL

@msevestre msevestre changed the title Cannot add a parameter to an inhibition/induction process? Parameter added to an inhibition/induction process should be GLOBAL Oct 6, 2022
@msevestre msevestre self-assigned this Oct 6, 2022
@msevestre msevestre added this to the Version 11 Update 1 milestone Oct 6, 2022
@PavelBal
Copy link
Member Author

PavelBal commented Oct 6, 2022

WHere can you change the type??

image

@PavelBal
Copy link
Member Author

PavelBal commented Oct 6, 2022

LOL, the "type" column is not shown be default...

@msevestre
Copy link
Member

msevestre commented Oct 6, 2022

right click on the header, drag the type column
It's not shown by default because in this case, it should ALWAYS BE GLOBAL

@msevestre msevestre moved this to In Progress in V11 - Update 1 Oct 6, 2022
Repository owner moved this from In Progress to Done in V11 - Update 1 Oct 7, 2022
@Yuri05 Yuri05 moved this from Done to Verified in V11 - Update 1 Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Verified
Development

No branches or pull requests

3 participants