Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11.1 Observed data not automatically mapped #800

Closed
Yuri05 opened this issue Nov 15, 2022 · 15 comments · Fixed by #828
Closed

11.1 Observed data not automatically mapped #800

Yuri05 opened this issue Nov 15, 2022 · 15 comments · Fixed by #828
Assignees

Comments

@Yuri05
Copy link
Member

Yuri05 commented Nov 15, 2022

e.g. here I have some data sets for Alfentanil, Peripheral Venous Blood, Plasma - and the curve is simulated
grafik
grafik

But when adding observed data to the chart: no mapping as per default
grafik

@msevestre
Copy link
Member

This I don't get. This should be the same code used in all application to do the mapping

@georgeDaskalakis georgeDaskalakis self-assigned this Nov 16, 2022
@rwmcintosh
Copy link
Member

Maybe this should be tried again with the latest build. I was working with this project in #801 and if I drop the data on the chart it maps automatically.

image

@rwmcintosh
Copy link
Member

Sorry, I wasn't working on #801. It was in Core. Open-Systems-Pharmacology/OSPSuite.Core#1794

@georgeDaskalakis
Copy link
Contributor

@Yuri05 cannot reproduce, when I manually create the same user case in my project, it gets mapped automatically. If you still have the issue could you attach a project so I can debug?

@PavelBal
Copy link
Member

Because its Peripheral Venous Blood in PK-Sim and Data, but PeripheralVenousBlood in MoBi... Because of this inconsistency it is also not possible to have one excel file structure that could be equally imported for PK-Sim and Mobi.

@Yuri05
Copy link
Member Author

Yuri05 commented Nov 18, 2022

@georgeDaskalakis @rwmcintosh With the latest Mobi (Core 11.1.60) I still have the same problem.
I think it's what @PavelBal said.

But: I changed the Organ of all observed data sets to "VenousBlood" and calculated "VenousBlood" as output.
Even here, adding obs data sets to the simulation does not map them automatically to the venous blood.

s. attached project: drag all obs data into the simulation, reopen it (refreshing of the observed data tab not working yet) and check the mappings: all set to none
P4.zip

@georgeDaskalakis
Copy link
Contributor

@Yuri05 I ll debug in the project and let you know ;)

@msevestre
Copy link
Member

Because of this inconsistency it is also not possible to have one excel file structure that could be equally imported for PK-Sim and Mobi.

Interesting.
At least now you can import in PKSim and export the observed data and the mapping to MoBi in one click

@georgeDaskalakis
Copy link
Contributor

@georgeDaskalakis @rwmcintosh With the latest Mobi (Core 11.1.60) I still have the same problem. I think it's what @PavelBal said.

But: I changed the Organ of all observed data sets to "VenousBlood" and calculated "VenousBlood" as output. Even here, adding obs data sets to the simulation does not map them automatically to the venous blood.

s. attached project: drag all obs data into the simulation, reopen it (refreshing of the observed data tab not working yet) and check the mappings: all set to none P4.zip

@Yuri05 When I follow the described steps I get this:

image

which I would say is a correct mapping. I am doing this on the latest develop of MoBi with the latest Core develop dlls copied. I think something that is not an issue anymore, still I suggest we keep it open so @Yuri05 can check once again on the beta that it is not reproducible anymore (cause if it still is something really weird is going on.)

@PavelBal
Copy link
Member

@Yuri05 could you check again?

@Yuri05
Copy link
Member Author

Yuri05 commented Nov 30, 2022

It does NOT work (MoBi 11.1.90 = latest nightly)
Even worse: #799 which was fixed, does not work anymore as well.

@PavelBal
Copy link
Member

PavelBal commented Dec 5, 2022

Cannot reproduce. Latest MoBi nightly (11.1.93), downloaded P4

Open simulation, dradndropp all obs data to the "Results"-tab, switch to "Observed data" - all is mapped there.

@Yuri05
Copy link
Member Author

Yuri05 commented Dec 6, 2022

Reproducible on my computer with 11.1.93 and P4. Showed it yesterday to @rwmcintosh

@msevestre
Copy link
Member

It works as expected here.
I am using it locally from vscodfe. I am going to use the latest build

@msevestre
Copy link
Member

@rwmcintosh @Yuri05 @georgeDaskalakis
However there is a cool bug. If I drag and drop the folder twice, (or single obs data), I get DUPLICATED mapping
image

One OBS data should only be mapped to one output right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants