Fixes #164. Fixes #1325 #1336
Merged
Fixes #164. Fixes #1325 #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msevestre
commented
May 2, 2024
| @@ -23,6 +23,7 @@ public EventAssignmentBuilderDTO MapFrom(EventAssignmentBuilder eventAssignmentB | |||
| dto.ChangedEntityPath = eventAssignmentBuilder.ObjectPath == null ? string.Empty : eventAssignmentBuilder.ObjectPath.PathAsString; | |||
| dto.NewFormula = _formulaDTOMapper.MapFrom(eventAssignmentBuilder.Formula); | |||
| dto.UseAsValue = eventAssignmentBuilder.UseAsValue; | |||
| dto.Dimension = eventAssignmentBuilder.Dimension; | |||
There was a problem hiding this comment.
typically not required because one points to the other but it's implementation details so why not
| bindToFormula(); | ||
| } | ||
|
|
||
| private void setObjectPath(string path, IDimension dimension) |
There was a problem hiding this comment.
The one and only function that is being used.
| AddCommand(new SetEventAssignmentObjectPathCommand(_eventAssignmentBuilder, objectPath, BuildingBlock).Run(_context)); | ||
| _view.TargetPath = objectPath.PathAsString; |
There was a problem hiding this comment.
Databinding gone wrong here
| _screenBinder.Bind(dto => dto.Name) | ||
| .To(btnName) | ||
| .To(tbName) |
There was a problem hiding this comment.
no idea why this was button and not a textbox. This was not used anywhere
| } | ||
| } | ||
|
|
||
| public class When_setting_the_dimension_of_the_target : concern_for_EditAssignmentBuilderPresenter |
There was a problem hiding this comment.
@rwmcintosh added some basic tests for what I was implementing.
rwmcintosh
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #164. Fixes #1325
Description
@rwmcintosh @PavelBal @Yuri05
So I am adding a new field to enter the dimension when the path is entered by hand./ This is required because we need to create a "FormulaUsablePath" and not an "ObjectPath" Like in most instances
Type of change
Please mark relevant options with an
xin the brackets.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Reviewer checklist
Mark everything that needs to be checked before merging the PR.
This change requires a documentation updateabove is selectedScreenshots (if appropriate):
Questions (if appropriate):