Litre are recognized #617
Merged
Litre are recognized #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msevestre
requested changes
Sep 28, 2021
|
|
||
| public IDimension TryGetDimensionCaseInsensitive(string dimensionName) | ||
| { | ||
| var dimension = Dimensions.FirstOrDefault(d => d.Name.Equals(dimensionName, StringComparison.OrdinalIgnoreCase)); | ||
| return dimension ?? NoDimension; | ||
| } | ||
|
|
||
| public IDimension TryGetDimensionCaseInsensitiveFromUnit(string unitName) | ||
| { | ||
| var dimension = Dimensions.FirstOrDefault(d => d.FindUnit(unitName, true) != null); |
There was a problem hiding this comment.
I think this is the method DimensionForUnit that does exactly that...
| return dimension; | ||
| if (_sbmlUnitsSynonyms.ContainsKey(unitName)) | ||
| { | ||
| dimension = Dimensions.FirstOrDefault(d => d.Units.Any(u => u.Name.Equals(_sbmlUnitsSynonyms[unitName], StringComparison.OrdinalIgnoreCase))); |
There was a problem hiding this comment.
Why not use the DimensionForUnit method here as well?
| msv.StartValue = _unitDefinitionImporter.ToMobiBaseUnit(sbmlUnit, new[] { sbmlSpecies.getInitialConcentration() })[0]; | ||
| var startValue = _unitDefinitionImporter.ToMobiBaseUnit(sbmlUnit, new[] { sbmlSpecies.getInitialConcentration() })[0]; | ||
| msv.StartValue = startValue; | ||
| msv.Formula = new ConstantFormula(startValue); |
There was a problem hiding this comment.
ConstantFormula should be created using the formulaFactory and dimension needs to be set
| @@ -92,4 +92,20 @@ public void SpeciesSameNameDiffCompartmentsTest() | |||
| mbb.Any(molecule => molecule.Name == "abc").ShouldBeTrue(); | |||
| } | |||
| } | |||
|
|
|||
| public class WhenSettingMoleculeStartValue : ContextForSBMLIntegration<SpeciesImporter> | |||
There was a problem hiding this comment.
When_setting_molecule_start_value
msevestre
deleted the
616_Litre_is_not_recognized_when_importing_from_sbml
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #616 (Litre are recognized as a unit when importing sbml files)