Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluging in new Simulation OutputMapings and Charts #777

Merged
merged 20 commits into from
Oct 26, 2022

Conversation

georgeDaskalakis
Copy link
Contributor

No description provided.

@georgeDaskalakis georgeDaskalakis self-assigned this Oct 20, 2022
@georgeDaskalakis georgeDaskalakis marked this pull request as draft October 20, 2022 15:39
@georgeDaskalakis
Copy link
Contributor Author

@msevestre converting this to a draft, since moving code from PK-Sim to Core will also affect this PR.

@georgeDaskalakis
Copy link
Contributor Author

@msevestre this is also ready with the latest Core dlls.

@georgeDaskalakis georgeDaskalakis marked this pull request as ready for review October 23, 2022 21:29
Copy link
Member

@msevestre msevestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The serialization isa problem
You need to name the mapping explicitly to be like the old one

@georgeDaskalakis
Copy link
Contributor Author

closes #749, close #778

@georgeDaskalakis
Copy link
Contributor Author

@msevestre tab renaming also done, I think this is also ready

@georgeDaskalakis
Copy link
Contributor Author

@msevestre is there something more to be changed for this PR? I would say this is ready for merging

@msevestre msevestre merged commit f8890ab into develop Oct 26, 2022
@msevestre msevestre deleted the plugin-simulation-charts branch October 26, 2022 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants