Fixes #801 no refresh of gof plots #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msevestre
commented
Nov 17, 2022
|
|
||
| if (simulation.Chart != null) | ||
| xElement.Add(chartSerializer.Serialize(simulation.Chart, serializationContext)); | ||
| addSerializedChart(simulationElement, simulation.Chart, serializationContext); |
There was a problem hiding this comment.
The charts were not saved in the simulation and also not serialized
| @@ -158,38 +156,44 @@ public override void Edit(object subject) | |||
|
|
|||
| private void loadChart() | |||
| { | |||
| if (_simulationPredictedVsObservedChartPresenter.Chart == null) | |||
| { | |||
| var chart = _chartFactory.Create<SimulationPredictedVsObservedChart>(); | |||
There was a problem hiding this comment.
this was creating a local chart in the presente.r gone as you as you close it
| if (_simulation.PredictedVsObservedChart == null) | ||
| _simulation.PredictedVsObservedChart = _chartFactory.Create<SimulationPredictedVsObservedChart>(); | ||
|
|
||
| if(_simulationPredictedVsObservedChartPresenter.Chart == null) |
There was a problem hiding this comment.
This code can be refactored for sure but this will be gone as soon as we are done with 11.1 so I don't think it needs optimizing. That being said, I'd like to know if this is right.
What I don't understand is why the identity curven is not drawn the first time (or the residual zeros)
There was a problem hiding this comment.
Let me see if there's a fast fix for that identity/residual 0 problem today.
rwmcintosh
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.