-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Computing residuals when scaling is logarithmic #1087
Comments
This was done to stay faithful to what is done in the reporting engine: But, yes, you are correct that |
Natural logarithm is correct. The residuals should follow then a lognormal distribution. |
Then the PK-Sim implementation is not correct? |
Let's say: uncommon. And not directly comparable to a lognormal distribution. |
Then I wonder, why in the "Histogram of residuals" in RE we plot normal distribution all the time??? @sfrechen |
Well, if the assumed error model is logarithmic, i.e. epsilon follows log normal distribution (which is usually the case), then plotting the logarithmized residuals against a normal distribution is correct (because If the assumed error model is linear, i.e. epsilon follows normal distribution, then plotting the "raw" residuals against normal distribution is also correct. Whether the residuals are logarithmized or not should depend on the underlying assumption of the error model! |
a) We don't plot |
Hm. As said: Whether the residuals are logarithmized or not should depend on the underlying assumption of the error model, i.e. if the parameter identification is done in log scale for an output, then the residuals should be calculated as
Sorry, I was not accurate: If the assumed error model is logarithmic, i.e. |
Do we have an agreement? |
log(x) is ln(x) in R, right?
Seems wrong to me, I would expect
log10(predicted)-log10(observed)
and notln(predicted)-ln(observed)
???Originally posted by @Yuri05 in #1085 (comment)
Referring to the code here:
OSPSuite-R/R/utilities-data-combined.R
Lines 234 to 238 in 1252a50
The text was updated successfully, but these errors were encountered: