- Use logSafe from utils package #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Calculate residuals using ln instead of log10
|
Natural logarithm is what expected by most people when calculating the residuals, so I guess it is safe to make this switch here. |
svavil
reviewed
Mar 7, 2023
| expect_equal(calculateResiduals(myDC, scaling = "log")$residualValues, | ||
| c(0, 0.022276400, -0.007178578, 0.00000000, -0.010723855, -20), | ||
| expectedResiduals, |
There was a problem hiding this comment.
Do we need to define expectedResiduals before using? Might have been left undefined.
There was a problem hiding this comment.
Line 88 is defining the expected residuals, or what do you mean?
There was a problem hiding this comment.
Do we need to define
expectedResidualsbefore using? Might have been left undefined.
possible but I think it's more clear like this. {testthat} will still give the details of which one is wrong (index and value):
> expected <- c(.001, 1, 4, 1e10^9)
> expect_equal(c(.001, 1, 3, 1e10^9), expected)Error: c(0.001, 1, 3, 1e+10^9) not equal to `expected`.
1/4 mismatches
[3] 3 - 4 == -1
Felixmil
approved these changes
Mar 7, 2023
|
@Yuri05 Would like to have your "go" on this before merging. |
Yuri05
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Residual calculation #1091, Computing residuals when scaling is logarithmic #1087, Use
.logSafe()from utils #1212