Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OutputSchema - errors in messages #451

Closed
PavelBal opened this issue Dec 1, 2020 · 1 comment
Closed

OutputSchema - errors in messages #451

PavelBal opened this issue Dec 1, 2020 · 1 comment

Comments

@PavelBal
Copy link
Member

PavelBal commented Dec 1, 2020

intervals = function(value) {
if (missing(value)) {
intervals <- rClr::clrGet(self$ref, "IntervalsAsArray")
toObjectType(intervals, Interval)
} else {
private$throwPropertyIsReadonly("solver")
}

should be private$throwPropertyIsReadonly("intervals")

In

private$wrapReadOnlyProperty("TimePoints", value)

and

private$wrapReadOnlyProperty("EndTime", value)

the names of the properties should not be capitalized (i.e., timePoints and endTime), and also in the following lines, as the names of the fields in R are in lower case.

@msevestre
Copy link
Member

The name of the props are the name or the .net methods which are capitalized so this should stay as is

Agreed with first point

@PavelBal PavelBal closed this as completed Dec 2, 2020
msevestre added a commit that referenced this issue Dec 14, 2020
* Fixes #446 ensure that object ids are resetted

* Fixes #446 ensure that object ids are resetted

* Do not use develop to ensure we can use the latest build\

* Fixes issue with pksim setup tmp

* Comment out tests until PKSim is ready

* Comment out tests until PKSim is ready

* Fixes #451 output schema error in messages

* Also fixes #452

* Also fixes #452

* Fixes #446 ensure that object ids are reset and fixes #457

* Fixes #446 ensure that object ids are reset and fixes #457

* add tests back to the suite for individual and population

* Fixes #456

* Fixes #450

* Fixes #445 error when setting readonly props

* Update ospsuite.core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants