Cli commands in ospsuite r #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- run simulations from snapshot files - convert between snapshot and project files + Add tests + Add test snapshot and project
rengelke
reviewed
Sep 5, 2024
|
Many unnecessary files added (.pdb, ConsoleApp, etc.) |
Yuri05
reviewed
Sep 5, 2024
R/snapshots.R
Outdated
| @@ -0,0 +1,116 @@ | |||
| #' Run Simulations From Snapshot Files | |||
| #' | |||
| #' @param ... character strings, path to snapshot files or a directory containing snapshot files | |||
There was a problem hiding this comment.
why not introducing an explicit parameter instead of ..., e.g.
runSimulationsFromSnapshot <- function(snaphotPathsOrFolder, output = ".", csv = TRUE, pkml = FALSE, xml = FALSE)
There was a problem hiding this comment.
Because this way we can pass several files or folder in one call:
runSimulationsFromSnapshot("snapshot.json","snapshotFolder", exportCSV = TRUE, exportPKML = TRUE) There was a problem hiding this comment.
Note that:
runSimulationsFromSnapshot(c("snapshot.json","snapshotFolder"), exportCSV = TRUE, exportPKML = TRUE)Will also work
There was a problem hiding this comment.
Note that:
runSimulationsFromSnapshot(c("snapshot.json","snapshotFolder"), exportCSV = TRUE, exportPKML = TRUE)Will also work
that's what I had in mind when suggesting introducing a named argument
There was a problem hiding this comment.
With ..., both work
Yuri05
reviewed
Sep 5, 2024
Yuri05
reviewed
Sep 5, 2024
Yuri05
reviewed
Sep 5, 2024
Yuri05
reviewed
Sep 5, 2024
+ prefix format with "export"
+ formating
#Conflicts: # DESCRIPTION # inst/lib/ConsoleApp.deps.json # inst/lib/ConsoleApp.dll # inst/lib/PKSim.Assets.Images.dll # inst/lib/PKSim.Assets.dll # inst/lib/PKSim.CLI.Core.dll # inst/lib/PKSim.Core.dll # inst/lib/PKSim.Infrastructure.dll # inst/lib/PKSim.Presentation.dll # inst/lib/PKSim.R.dll
Yuri05
previously approved these changes
Sep 9, 2024
rengelke
previously approved these changes
Sep 9, 2024
rengelke
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created on 2024-09-05 with reprex v2.1.0