Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #467 Disable "Windows-only" tests if running under Linux #474

Merged
merged 4 commits into from
Mar 2, 2021
Merged

Fixes #467 Disable "Windows-only" tests if running under Linux #474

merged 4 commits into from
Mar 2, 2021

Conversation

Yuri05
Copy link
Member

@Yuri05 Yuri05 commented Feb 25, 2021

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #474 (1ed0e6c) into develop (ecb2bb4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #474   +/-   ##
========================================
  Coverage    88.15%   88.15%           
========================================
  Files           68       68           
  Lines         1216     1216           
========================================
  Hits          1072     1072           
  Misses         144      144

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecb2bb4...1ed0e6c. Read the comment docs.

@msevestre
Copy link
Member

@Yuri05 I just triggered a new build for this one

@msevestre
Copy link
Member

Going to merge this

@msevestre msevestre merged commit 115dd00 into Open-Systems-Pharmacology:develop Mar 2, 2021
@msevestre
Copy link
Member

@Yuri05 Build is still failing. I have no idea why

@msevestre
Copy link
Member

WTF
image

I think this package was just updated and the one required is not available anymore!

@msevestre
Copy link
Member

image
vs
image

@Yuri05
Copy link
Member Author

Yuri05 commented Mar 2, 2021

Well, no idea. We can wait couple of days and retry then
grafik

@Yuri05 Yuri05 deleted the TestsIgnoreLinux branch May 28, 2021 15:46
PavelBal pushed a commit that referenced this pull request Aug 10, 2023
@Felixmil
Adapt to tlf #474 (#1275)
d634193 
* replace createPlotFont() by createPlotTextBoxFont() since it changed in TLF

* Change createPlotTextBoxFont to createPlotTextFont
since legend title is managed by ggplot2::element_text() and not ggtext::element_textbox()

* update snaps with latest tlf version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yuri05 @codecov-io @msevestre