Using low-level rCrl methods in getOutputValues #518
Conversation
|
See #519 |
Codecov Report
@@ Coverage Diff @@
## develop #518 +/- ##
===========================================
+ Coverage 88.46% 88.53% +0.06%
===========================================
Files 72 72
Lines 1422 1439 +17
===========================================
+ Hits 1258 1274 +16
- Misses 164 165 +1
Continue to review full report at Codecov.
|
|
@msevestre You can review now. I am using the "fromPath" methods implemented in Core. |
|
You have to teach me how to correctly update package versions... |
|
Let me do this for you:) |
Better so :D |
| #' | ||
| #' setParameterValuesByPath(list("Organism|Liver|Volume", "Organism|Liver|A"), c(2, 3), sim) | ||
| #' @export | ||
| setQuantityValuesByPath <- function(quantityPaths, values, simulation) { |
There was a problem hiding this comment.
@msevestre Implementation using the .NET method for setting values by path
R/utilities-parameter.R
Outdated
| validateIsOfType(simulation, Simulation) | ||
| parameters <- sapply(parameterPaths, function(p) getParameter(p, simulation)) | ||
| setParameterValues(parameters, values) | ||
| setQuantityValuesByPath(quantityPaths = parameterPaths, values = values, |
There was a problem hiding this comment.
setParameterValuesByPath can simply use setQuantityValuesByPath
|
Open questions:
|
- Argument 'withMetaData' in 'getOutputValues' renamed to 'addMetaData'
|
@PavelBal I updated to use single version of the methods . IsExplicitFormulaFromPath is never used anywhere so I am not sure where this is going to break |
…ystems-Pharmacology/OSPSuite-R into performance-optimizations
|
@msevestre OK I think we are good to merge. |
|
@PavelBal Be mindful of method rename and behavior. IsExplicitFormulasFromPath => IsExplicitFormulaByPath |
No description provided.