Fixes #581 batch run crash #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msevestre
commented
Aug 25, 2021
| @@ -24,7 +24,7 @@ DataSet <- R6::R6Class( | |||
| private$.dataRepository$name <- value | |||
| }, | |||
|
|
|||
| #' @field name The underlying DataRepository object | |||
| #' @field dataRepository The underlying DataRepository object | |||
There was a problem hiding this comment.
@PavelBal Copy paste issue here
| @@ -70,6 +70,8 @@ SimulationBatch <- R6::R6Class( | |||
| #' Clears the reference to the wrapped .NET object | |||
| finalize = function() { | |||
| private$.simulation <- NULL | |||
| # SimulationBatch are disposable object and should be disposed | |||
| rClr::clrCall(self$ref, "Dispose") | |||
There was a problem hiding this comment.
Calling dispose on finalize
| @@ -311,7 +311,7 @@ runSimulationBatches <- function(simulationBatches, simulationRunOptions = NULL, | |||
| # All results of this batch have the id of the same simulation | |||
| resultsIdSimulationIdMap[valuesIds] <- simBatchId | |||
| # Add the batch to concurrent runner | |||
| rClr::clrCall(simulationRunner, "AddSimulationBatchOption", simBatch$ref) | |||
| rClr::clrCall(simulationRunner, "AddSimulationBatch", simBatch$ref) | |||
There was a problem hiding this comment.
Updating the nomenclature
Codecov Report
@@ Coverage Diff @@
## develop #590 +/- ##
========================================
Coverage 89.78% 89.79%
========================================
Files 74 74
Lines 1674 1675 +1
========================================
+ Hits 1503 1504 +1
Misses 171 171
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.