Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change round brackets to square brackets in dimension names #608

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

abdullahhamadeh
Copy link
Member

Enables intellisense in ospUnits lists such as Concentration (Mass)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Enables intellisense in ospUnits lists such as Concentration (Mass)
@PavelBal
Copy link
Member

PavelBal commented Sep 9, 2021

Looks good for me.

@msevestre
Copy link
Member

Build is failing but this is because pksim interface has changed. Will update

@msevestre msevestre closed this Sep 9, 2021
@PavelBal
Copy link
Member

This has been closed without merging. @msevestre will it be updated?

@msevestre msevestre reopened this Sep 15, 2021
@msevestre
Copy link
Member

This was a mistake. I wanted to merge jt

@msevestre msevestre merged commit ee9ebd6 into develop Sep 15, 2021
@msevestre msevestre deleted the fixes-#563 branch September 15, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants