Swap simulations (#1777)

Open-Systems-Pharmacology · Nov 29, 2022 · 7924bf2 · 7924bf2
1 parent efdd866
commit 7924bf2
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/src/OSPSuite.Core/Domain/OutputMapping.cs b/src/OSPSuite.Core/Domain/OutputMapping.cs
@@ -49,10 +49,7 @@ public virtual OutputMapping Clone()
          };
       }
 
-      public void UpdateSimulation(ISimulation newSimulation)
-      {
-         OutputSelection.UpdateSimulation(newSimulation);
-      }
+      public void UpdateSimulation(ISimulation newSimulation) => OutputSelection.UpdateSimulation(newSimulation);
 
       public bool DimensionsAreConsistentForParameterIdentification(DataRepository observedData)
       {

diff --git a/src/OSPSuite.Core/Domain/OutputMappings.cs b/src/OSPSuite.Core/Domain/OutputMappings.cs
@@ -37,6 +37,12 @@ public void RemoveOutputsReferencing(ISimulation simulation)
             .ToList().Each(x => _allOutputMappings.Remove(x));
       }
 
+      public virtual void SwapSimulation(ISimulation oldSimulation, ISimulation newSimulation)
+      {
+         //Use ToList() here as the collection might be modified as we iterate
+         _allOutputMappings.Where(x => x.UsesSimulation(oldSimulation)).ToList().Each(x => x.UpdateSimulation(newSimulation));
+      }
+
       private bool outputBelongsToSimulation(ISimulation simulation, OutputMapping outputMapping)
       {
          return Equals(outputMapping.Simulation, simulation);

diff --git a/src/OSPSuite.Core/Domain/ParameterIdentifications/ParameterIdentification.cs b/src/OSPSuite.Core/Domain/ParameterIdentifications/ParameterIdentification.cs
@@ -235,8 +235,7 @@ public IEnumerable<string> DistinctCompoundNames()
 
       public virtual void SwapSimulations(ISimulation oldSimulation, ISimulation newSimulation)
       {
-         //Use ToList() here as the collection might be modified as we iterate
-         AllOutputMappings.Where(x => x.UsesSimulation(oldSimulation)).ToList().Each(x => x.UpdateSimulation(newSimulation));
+         OutputMappings.SwapSimulation(oldSimulation, newSimulation);
          AllIdentificationParameters.Each(identificationParameter => identificationParameter.SwapSimulation(oldSimulation, newSimulation));
          _allSimulations.Remove(oldSimulation);
          _allSimulations.Add(newSimulation);