Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons that need implementations #1888

Closed
rwmcintosh opened this issue Feb 6, 2023 · 10 comments · Fixed by #2306
Closed

Icons that need implementations #1888

rwmcintosh opened this issue Feb 6, 2023 · 10 comments · Fixed by #2306
Assignees
Milestone

Comments

@rwmcintosh
Copy link
Member

rwmcintosh commented Feb 6, 2023

Edit this comment to add icons as we go

  • PKSim modules
  • Extension modules
  • PKSim modules folder
  • Extension modules folder
  • Neighborhood
@rwmcintosh
Copy link
Member Author

Another placeholder icon #1890

@msevestre
Copy link
Member

@rwmcintosh Do we have a list of all the icons we need? I need to add to that list neighborhood

@rwmcintosh
Copy link
Member Author

For now, I think it's just Modules and the relevant modules 'folders'

Pk-Sim Modules + folder
Extension Modules + folder

I'll change this issue to collect the list of all icons needed.

@rwmcintosh rwmcintosh changed the title Replace icons with appropriate symbols for "Modules" Icons that need implementations Mar 9, 2023
@rwmcintosh rwmcintosh added this to v12 Mar 30, 2023
@rwmcintosh rwmcintosh added this to the OSMOSES Cleanup milestone Mar 30, 2023
@rwmcintosh rwmcintosh moved this to Accepted in v12 Mar 30, 2023
@rwmcintosh
Copy link
Member Author

We are removing 'Extension Modules' from the UI.

Open-Systems-Pharmacology/MoBi#981

We will need a distinct icon for modules that come from PK-Sim so they can be differentiated in another way in the UI

@msevestre
Copy link
Member

I think the same icon, just different colors would be enough?

@msevestre
Copy link
Member

Hovering over would show all the meta info (PKSimVersion, read-only etc..)

@rwmcintosh
Copy link
Member Author

rwmcintosh commented May 4, 2023

We'll need to revise the MSV and PSV building block icons to use different initials now.

There are several variants of each type. Now called InitialConditons and ParameterValues (red, green, save, import)

@rwmcintosh rwmcintosh modified the milestones: OSMOSES Cleanup, Version 12 Nov 6, 2023
@rwmcintosh
Copy link
Member Author

rwmcintosh commented May 21, 2024

From our newly added icons (currently marked as TODO in OSPSuite.Core)

  • ModuleExplorer (This is the dockable view replacing BB explorer)
  • ModulesFolder
  • Module
  • ModuleGreen
  • ModuleRed
  • PKSimModule
  • PKSimModuleGreen
  • PKSimModuleRed
  • Neighborhood
  • Neighbor

We need modification to PSV and MSV icons

  • ParameterValues
  • ParameterValuesAdd
  • ParameterValuesFolder
  • ParameterValuesGreen
  • ParameterValuesImport
  • ParameterValuesLoad
  • ParameterValuesRed
  • ParameterValuesSave
  • ExtendParameterValues
  • InitialConditions
  • InitialConditionsAdd
  • InitialConditionsFolder
  • InitialConditionsGreen
  • InitialConditionsImport
  • InitialConditionsLoad
  • InitialConditionsRed
  • InitialConditionsSave
  • ExtendInitialConditions

We need an overall concept for Module icon. With that, all the variations are taken care of.
We also need a concept for Neighborhood/Neighbor

@Yuri05 @PavelBal @msevestre any concepts you've been thinking of?

image
Or
image

image

@Yuri05
Copy link
Member

Yuri05 commented May 22, 2024

Maybe something like this (modified in the way that the brick on top comes down with an arrow, similar to your first image)?
Unbenannt-1

@rwmcintosh rwmcintosh moved this from Accepted to In Progress in v12 May 22, 2024
@rwmcintosh
Copy link
Member Author

Maybe something like this (modified in the way that the brick on top comes down with an arrow, similar to your first image)? Unbenannt-1

I think this is too much detail for a 16x16 px image

@rwmcintosh rwmcintosh self-assigned this Aug 13, 2024
rwmcintosh added a commit that referenced this issue Aug 19, 2024
@rwmcintosh rwmcintosh linked a pull request Aug 19, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Fixed in v12 Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Fixed
Development

Successfully merging a pull request may close this issue.

3 participants