Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11.3 Crash in cloned PI after project save/load #2217

Closed
Yuri05 opened this issue Mar 19, 2024 · 4 comments · Fixed by #2219
Closed

11.3 Crash in cloned PI after project save/load #2217

Yuri05 opened this issue Mar 19, 2024 · 4 comments · Fixed by #2219
Assignees

Comments

@Yuri05
Copy link
Member

Yuri05 commented Mar 19, 2024

03_Carbamazepine_11.3.pksim5.zip

  • Open the project attached
  • Clone parameter identification PI1 to PI2. Cloned PI looks good so far
  • Save the project and close it
  • Reopen the project and open PI2 - the error below comes
Application:
PK-Sim® 11.3.197

Array cannot be null.
Parameter name: bytes

Stack trace:
at System.Text.Encoding.GetString(Byte[] bytes)
   at OSPSuite.Serializer.Xml.XmlHelper.ElementFromBytes(Byte[] serializationByte)
   at PKSim.Infrastructure.Serialization.Xml.XmlSerializationManager.ElementFrom(Byte[] serializationBytes)
   at PKSim.Infrastructure.Serialization.Xml.XmlSerializationManager.getConvertedElementFrom(Byte[] serializationBytes)
   at PKSim.Infrastructure.Serialization.Xml.XmlSerializationManager.Deserialize[TObject](TObject objectToDeserialize, Byte[] serializationBytes, SerializationContext serializationContext)
   at PKSim.Core.Services.CompressedSerializationManager.Deserialize[TObject](TObject objectToDeserialize, Byte[] serializationBytes, SerializationContext serializationContext)
   at PKSim.Infrastructure.Services.ParameterIdentificationContentLoader.LoadContentFor(ParameterIdentification parameterIdentification)
   at PKSim.Infrastructure.Services.LazyLoadTask.Load[TObject](TObject objectToLoad)
   at PKSim.Presentation.Core.SingleStartPresenterTask.<>c__DisplayClass5_0`1.<StartForSubject>b__0()
...
  • After click on "Close": PI opens and is totally corrupted
@Yuri05
Copy link
Member Author

Yuri05 commented Mar 19, 2024

11.2 has the same problem

@msevestre
Copy link
Member

OH MY GOSH! Can you reproduce this consistently?
Finally an example

@rwmcintosh
Copy link
Member

Content is NULL in the project database. Not surprising. So, why does it get stored like that? Investigating rn.

image

@rwmcintosh
Copy link
Member

Could be added to this hotfix I think. I'll PR into 11.3 and we can see.

@rwmcintosh rwmcintosh transferred this issue from Open-Systems-Pharmacology/PK-Sim Mar 20, 2024
msevestre pushed a commit that referenced this issue Mar 20, 2024
* Fixes #2217 11.3 Crash in cloned PI after project save/load

* Moved this implementation of setting HasChanged into cloneManagerStrategy

* add interface to other core objects with the property
rwmcintosh added a commit that referenced this issue Mar 21, 2024
rwmcintosh added a commit that referenced this issue Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Verified
Development

Successfully merging a pull request may close this issue.

3 participants