Fixes #878 yAxis normalization of residuals distribution (#943)

Open-Systems-Pharmacology · Oct 20, 2022 · e1989c4 · e1989c4
1 parent 5998747
commit e1989c4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/R/gof-plot-task.R b/R/gof-plot-task.R
@@ -425,7 +425,8 @@ GofPlotTask <- R6::R6Class(
             x = "Residuals",
             fill = "Legend",
             stack = TRUE,
-            distribution = "normal"
+            distribution = "normal",
+            frequency = TRUE
           ),
           plotConfiguration = settings$plotConfigurations[["histogram"]],
           bins = settings$bins %||% reEnv$defaultBins

diff --git a/R/reportingengine-env.R b/R/reportingengine-env.R
@@ -58,7 +58,7 @@ reEnv$defaultPlotFormat <- list(
 reEnv$fontScaleFactor <- 2
 
 reEnv$workflowWatermarkMessage <- "preliminary analysis"
-reEnv$residualsHistogramLabel <- "Number of residuals"
+reEnv$residualsHistogramLabel <- "Relative frequency"
 reEnv$residualsQQLabel <- "Quantiles of residuals"
 
 # Default values for qualification pk ratio

diff --git a/R/utilities-goodness-of-fit.R b/R/utilities-goodness-of-fit.R
@@ -1223,7 +1223,8 @@ getResidualsPlotResults <- function(timeRange, residualsData, metaDataFrame, str
       x = "Residuals",
       fill = "Legend",
       stack = TRUE,
-      distribution = "normal"
+      distribution = "normal",
+      frequency = TRUE
     ),
     plotConfiguration = settings$plotConfigurations[["resHisto"]],
     bins = settings$bins %||% reEnv$defaultBins