-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
timeOffset should be set for each simulation within a workflow #313
Comments
not for RE 1.0 |
|
Yes.
No, probably for PK parameter calculation as well. Implementation to be discussed.
|
One possibility to implement this would be: instead of shifting the simulation results: Not sure if this is better/easier to implement - to be discussed. Advantage: PK calculation and all tasks (time profiles etc) know nothing about the shift and behave exactly as before. |
@sfrechen , can you let me know if this what is expected from the
|
Yes. This looks correct to me. It is a but hard to judge wrt. observed data (since the names do not match with the simulations and are generally pretty off ;-). Are they also shifted?
The total range looks also correct. I just do not understand the warning
I think here the upper warning would make sense and the plot should not be generated. |
should we really don't generate the first app plot in this case? |
Yes. I would not plot administrations for which |
The observed data are also shifted. |
Then, I'll update the warning with only I should be able to prevent the plot to be output in such a case.
|
…n set for shifting time While fixing this issue, I imported ospsuite.utils in NAMESPACE so ospsuite.utils:: should not be necessary any longer
As specified in #18 :
We need to define an optional timeOffset for each simulation within a workflow. Default should be 0.
Both the simulation and connected data should be shifted by the timeOffset, i.e.
simulationTime - timeOffset
This is needed if the reference simulation differs in the study design compared to the simulations to be compared.
The text was updated successfully, but these errors were encountered: