Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demography plots should contain observed data for comparison #535

Closed
sfrechen opened this issue Sep 13, 2021 · 8 comments
Closed

Demography plots should contain observed data for comparison #535

sfrechen opened this issue Sep 13, 2021 · 8 comments

Comments

@sfrechen
Copy link
Member

See examples here from Matlab Reporting Engine 2.1:

Age

image

Body weight

image

Body height

image

BMI

image

Gender

image

@AnnikaRPS @Christoph27 @Yuri05

@sfrechen
Copy link
Member Author

Actually, this is high prio as this is expected from reports to regulatory agencies.

@Yuri05 Yuri05 closed this as completed Sep 14, 2021
@Yuri05 Yuri05 reopened this Sep 14, 2021
@Yuri05
Copy link
Member

Yuri05 commented Sep 14, 2021

@sfrechen For the demography data selection from the data files: which data filter should be used?
At the moment, when creating a workflow from excel, we have 2 data filters:

  • on the simulation set level
  • on the output level

In a created workflow, data filter is defined per output and is the concatenation of the 2 data filters above.

For the demography data:

  • should it be the "simulation set" filter?
  • or a new "demography data" filter?

@sfrechen
Copy link
Member Author

@Yuri05
It should be the "simulation set" filter.

@pchelle
Copy link
Collaborator

pchelle commented Jun 21, 2023

From issue #17 , there are a few types of plots exported by the demography task.
@sfrechen could you confirm which ones need observed data (if not all) and how you wish it to be displayed.

  • Pediatric histograms
    • observed not included
    • observed included within same plot
    • addition of a comparison histogram only between observed
  • Parallel/Ratio comparison histograms:
    • observed not included
    • observed included
  • Range plots
    • observed not included
    • observed included as scatter points
    • observed included as range plot

@pchelle
Copy link
Collaborator

pchelle commented Jun 21, 2023

Also I've noticed that the histograms display the number of virtual subjects (without ylabel) but not frequency within their respective population. I'll also fix this while adding the observed data.

@pchelle
Copy link
Collaborator

pchelle commented Jun 21, 2023

Last question regarding the dodging of the histogram bars.
The histograms look good for categorical variables such as Gender, but not so good when continuous variables are displayed along many populations

Example

8_demography_Organism_BMI

Let me know if you wish an option that prevents the dodging and display the histograms on top of each other with transparency.

@sfrechen
Copy link
Member Author

Let me know if you wish an option that prevents the dodging and display the histograms on top of each other with transparency.

Sounds reasonable to me!

@sfrechen
Copy link
Member Author

sfrechen commented Jun 22, 2023

My proposal:

  • Pediatric histograms

    • observed not included
    • observed included within same plot
    • addition of a comparison histogram only between observed
  • Parallel/Ratio comparison histograms:

    • observed not included
    • observed included
  • Range plots

    • observed not included
    • observed included as scatter points
    • observed included as range plot

pchelle added a commit to pchelle/OSPSuite.ReportingEngine that referenced this issue Jul 31, 2023
pchelle added a commit to pchelle/OSPSuite.ReportingEngine that referenced this issue Jul 31, 2023
…e binning

Binning for reference population is used by default but can be set to global range by new setting
@Yuri05 Yuri05 closed this as completed in 305bfd5 Aug 4, 2023
@Yuri05 Yuri05 moved this to Verified in Version 2.1 / 2.2 Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Verified
Development

No branches or pull requests

3 participants