Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report folder does not content images references by the md #955

Closed
msevestre opened this issue Nov 18, 2022 · 4 comments
Closed

Report folder does not content images references by the md #955

msevestre opened this issue Nov 18, 2022 · 4 comments
Assignees

Comments

@msevestre
Copy link
Member

I am sure there is a way to make it work. For now, the images references statically are not copied in the report folder
image

So it looks like the image is missing

https://github.com/Open-Systems-Pharmacology/Qualification-CKD/blob/952e1fbc9da1428ccd7c0bfb855c6117efc08efe/Qualification/report/report.md

How do I make this work? I know there are some instructions regarding files to be copied. How does this work again?

@pchelle @Yuri05

@Yuri05
Copy link
Member

Yuri05 commented Nov 18, 2022

as far as I remember, eveything under Content/images is automatically copied under <report-folder>/images #618
Can you see those images under re_input/Content/images?

@msevestre
Copy link
Member Author

msevestre commented Nov 18, 2022 via email

@Yuri05
Copy link
Member

Yuri05 commented Nov 18, 2022

Yep, seems to be s Bug.
@pchelle can you check please?

@pchelle
Copy link
Collaborator

pchelle commented Nov 21, 2022

The issue is that there are brackets (...) within the file name of the figure link/path.
When copying the report and its figures, the algorithm I implemented

1- finds lines where the characters ![ are found
2- removes everything until ]( and everything after the next ) to get the figure path
3- copy the figure path in the new folder

Here the figure path is truncated due to the brackets within the link and the corresponding path does not exist.

pchelle added a commit to pchelle/OSPSuite.ReportingEngine that referenced this issue Apr 13, 2023
…extracted from report

Note that the function `getFigurePathsFromReport` is export so that users can query their report and find all the figure paths it linked
@Yuri05 Yuri05 closed this as completed in 8577698 Apr 13, 2023
@Yuri05 Yuri05 moved this to Fixed in Version 2.1 / 2.2 Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Fixed
Development

No branches or pull requests

3 participants