Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #382 document word report template #1065

Merged
merged 5 commits into from
Jun 26, 2023

Conversation

pchelle
Copy link
Collaborator

@pchelle pchelle commented Jun 15, 2023

No description provided.

@pchelle pchelle marked this pull request as ready for review June 23, 2023 18:43
Comment on lines +228 to +233
lineContent <- gsub(pattern = "</div>", replacement = '', lineContent)
lineContent <- gsub(pattern = '<div align=\"right\">', replacement = '`<w:pPr><w:jc w:val="right"/></w:pPr>`{=openxml}', lineContent)
lineContent <- gsub(pattern = '<div align=\"left\">', replacement = '`<w:pPr><w:jc w:val="left"/></w:pPr>`{=openxml}', lineContent)
lineContent <- gsub(pattern = '<div align=\"center\">', replacement = '`<w:pPr><w:jc w:val="center"/></w:pPr>`{=openxml}', lineContent)
lineContent <- gsub(pattern = '<div align=\"justify\">', replacement = '`<w:pPr><w:jc w:val="both"/></w:pPr>`{=openxml}', lineContent)

Copy link
Member

@Yuri05 Yuri05 Jun 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pchelle
As far as I can see, if I have something like <div align="center"> Tralala </div> it will be replaced by
<w:pPr><w:jc w:val="center"/></w:pPr>{=openxml} Tralala
Does the open xml setting then apply for the rest of the line (and the next line is not affected)?

If I have a table with the div setting in every cell - will the openxml setting then be applied just to the cell?

<div align="center"> Header</div> <div align="center">Header </div>
<div align="left">Cell </div> <div align="left"> Cell </div>
<div align="left">Cell</div> <div align="left"> Cell </div>

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, both inline and block openxml <w:pPr><w:jc w:val="center"/></w:pPr> only center the next line(s) as long as they are in the same paragraph.

|**C_max**                        |Number |Ratio [%] |
|:----------------------------|:------|:---------|
|Points total                 |`<w:pPr><w:jc w:val="right"/></w:pPr>`{=openxml} 2      |-        |
|Points within Guest *et al.* |`<w:pPr><w:jc w:val="center"/></w:pPr>`{=openxml} 0      |0         |
|Points within 2 fold         |`<w:pPr><w:jc w:val="left"/></w:pPr>`{=openxml}2      |100       |

converts into

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Didn't expect so much intelligence from openXML :)

@Yuri05
Copy link
Member

Yuri05 commented Jun 25, 2023

Please fix spelling

Spelling

  WORD                                 FOUND IN
aA                                   word-report.Rmd:189
addLLOQLegend                        addLLOQLegend.Rd:5
aes                                  getLegendAesOverride.Rd:17
bB                                   word-report.Rmd:189
cC                                   word-report.Rmd:189
confiuration                         getGuestDeltaFromConfigurationPlan.Rd:10
dA                                   word-report.Rmd:189
dC                                   word-report.Rmd:189
dt                                   word-report.Rmd:189
eg                                   getDefaultPropertiesFromTheme.Rd:14,18
errorbars                            getDefaultPropertiesFromTheme.Rd:16
getDefaultPropertyFromTheme          getDefaultPropertiesFromTheme.Rd:5
getFigurePathsFromReport             getFigurePathsFromReport.Rd:5
getGuestDeltaFromConfigurationPlan   getGuestDeltaFromConfigurationPlan.Rd:5
getLegendAesOverride                 getLegendAesOverride.Rd:5
getMassBalanceDataMapping            getMassBalanceDataMapping.Rd:5
getMassBalancePlotConfiguration      getMassBalancePlotConfiguration.Rd:5
Github                               word-report.Rmd:36,65
LateX                                word-report.Rmd:167,170
openxml                              word-report.Rmd:215,224
plotTimeProfile                      getDefaultPropertiesFromTheme.Rd:14
rightarrow                           word-report.Rmd:189
tolower                              ConfigurationShapes.Rd:16
updateArtifactNumbers                updateArtifactNumbers.Rd:5
updateAxesMargin                     updateAxesMargin.Rd:5

inst/WORDLIST Outdated
@@ -259,6 +275,7 @@ getXParametersForDemogrpahyPlot
getXParametersForPKParametersPlot
getYParametersForDemogrpahyPlot
getYParametersForPKParametersPlot
Github
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this one.
It should be GitHub with capital H, then it will be accepted

inst/WORDLIST Outdated
@@ -289,6 +306,7 @@ jsonlite
knitr
Kubernetes
lastPathElement
LateX
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here. please remove the entry from the wordlist and use LaTeX in the text (capital T)

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (fd5ecd8) 76.76% compared to head (49a3e9b) 76.77%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1065      +/-   ##
===========================================
+ Coverage    76.76%   76.77%   +0.01%     
===========================================
  Files           64       64              
  Lines         8750     8754       +4     
===========================================
+ Hits          6717     6721       +4     
  Misses        2033     2033              
Impacted Files Coverage Δ
R/qualification-ddi.R 11.86% <ø> (ø)
R/utilities-writing-report.R 93.11% <100.00%> (+0.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Yuri05 Yuri05 merged commit ff7c7e5 into Open-Systems-Pharmacology:develop Jun 26, 2023
@pchelle pchelle deleted the 382_word_report branch February 15, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants