-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #382 document word report template #1065
Fixes #382 document word report template #1065
Conversation
lineContent <- gsub(pattern = "</div>", replacement = '', lineContent) | ||
lineContent <- gsub(pattern = '<div align=\"right\">', replacement = '`<w:pPr><w:jc w:val="right"/></w:pPr>`{=openxml}', lineContent) | ||
lineContent <- gsub(pattern = '<div align=\"left\">', replacement = '`<w:pPr><w:jc w:val="left"/></w:pPr>`{=openxml}', lineContent) | ||
lineContent <- gsub(pattern = '<div align=\"center\">', replacement = '`<w:pPr><w:jc w:val="center"/></w:pPr>`{=openxml}', lineContent) | ||
lineContent <- gsub(pattern = '<div align=\"justify\">', replacement = '`<w:pPr><w:jc w:val="both"/></w:pPr>`{=openxml}', lineContent) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pchelle
As far as I can see, if I have something like <div align="center"> Tralala </div>
it will be replaced by
<w:pPr><w:jc w:val="center"/></w:pPr>{=openxml} Tralala
Does the open xml setting then apply for the rest of the line (and the next line is not affected)?
If I have a table with the div setting in every cell - will the openxml setting then be applied just to the cell?
<div align="center"> Header</div> |
<div align="center"> Header </div> |
---|---|
<div align="left"> Cell </div> |
<div align="left"> Cell </div> |
<div align="left"> Cell</div> |
<div align="left"> Cell </div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, both inline and block openxml <w:pPr><w:jc w:val="center"/></w:pPr>
only center the next line(s) as long as they are in the same paragraph.
|**C_max** |Number |Ratio [%] |
|:----------------------------|:------|:---------|
|Points total |`<w:pPr><w:jc w:val="right"/></w:pPr>`{=openxml} 2 |- |
|Points within Guest *et al.* |`<w:pPr><w:jc w:val="center"/></w:pPr>`{=openxml} 0 |0 |
|Points within 2 fold |`<w:pPr><w:jc w:val="left"/></w:pPr>`{=openxml}2 |100 |
converts into
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Didn't expect so much intelligence from openXML :)
Please fix spelling Spelling
|
inst/WORDLIST
Outdated
@@ -259,6 +275,7 @@ getXParametersForDemogrpahyPlot | |||
getXParametersForPKParametersPlot | |||
getYParametersForDemogrpahyPlot | |||
getYParametersForPKParametersPlot | |||
Github |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this one.
It should be GitHub
with capital H, then it will be accepted
inst/WORDLIST
Outdated
@@ -289,6 +306,7 @@ jsonlite | |||
knitr | |||
Kubernetes | |||
lastPathElement | |||
LateX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here. please remove the entry from the wordlist and use LaTeX
in the text (capital T)
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #1065 +/- ##
===========================================
+ Coverage 76.76% 76.77% +0.01%
===========================================
Files 64 64
Lines 8750 8754 +4
===========================================
+ Hits 6717 6721 +4
Misses 2033 2033
☔ View full report in Codecov by Sentry. |
No description provided.