We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There's some additional stuff in the splash screen and also in the title bar when running a non-release build
We are generating this through some built-in attributes of the assembly when non-release
private string retrieveReleaseDescription() { var informationalVersionAttribute = Assembly.GetEntryAssembly() ?.GetCustomAttributes(typeof(AssemblyInformationalVersionAttribute), inherit: false) .OfType<AssemblyInformationalVersionAttribute>() .FirstOrDefault(); return string.IsNullOrEmpty(informationalVersionAttribute?.InformationalVersion) ? FullVersion : informationalVersionAttribute.InformationalVersion; }
This was introduced in an SDK update and an issue registered and documented
When I add the attribute to the PKSim.csproj in a PropertyGroup, then we get the old behavior.
PropertyGroup
<IncludeSourceRevisionInInformationalVersion>false</IncludeSourceRevisionInInformationalVersion>
To be investigated, is this only a problem in non-release builds? Or do we need to fix this?
The text was updated successfully, but these errors were encountered:
Fixes #2887 Commit ID included in version strings #2887
b16f0eb
Fixes #2887 Commit ID included in version strings #2887 (#2896)
68f620a
rwmcintosh
Successfully merging a pull request may close this issue.
There's some additional stuff in the splash screen and also in the title bar when running a non-release build
We are generating this through some built-in attributes of the assembly when non-release
This was introduced in an SDK update and an issue registered and documented
When I add the attribute to the PKSim.csproj in a
PropertyGroup
, then we get the old behavior.<IncludeSourceRevisionInInformationalVersion>false</IncludeSourceRevisionInInformationalVersion>
To be investigated, is this only a problem in non-release builds? Or do we need to fix this?
The text was updated successfully, but these errors were encountered: