Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit ID included in version strings #2887

Closed
rwmcintosh opened this issue Mar 27, 2024 · 0 comments · Fixed by #2896
Closed

Commit ID included in version strings #2887

rwmcintosh opened this issue Mar 27, 2024 · 0 comments · Fixed by #2896
Assignees
Milestone

Comments

@rwmcintosh
Copy link
Member

There's some additional stuff in the splash screen and also in the title bar when running a non-release build
image

We are generating this through some built-in attributes of the assembly when non-release

      private string retrieveReleaseDescription()
      {
         var informationalVersionAttribute = Assembly.GetEntryAssembly()
            ?.GetCustomAttributes(typeof(AssemblyInformationalVersionAttribute), inherit: false)
            .OfType<AssemblyInformationalVersionAttribute>()
            .FirstOrDefault();

         return string.IsNullOrEmpty(informationalVersionAttribute?.InformationalVersion) ? FullVersion : informationalVersionAttribute.InformationalVersion;
      }

This was introduced in an SDK update and an issue registered and documented

When I add the attribute to the PKSim.csproj in a PropertyGroup, then we get the old behavior.

<IncludeSourceRevisionInInformationalVersion>false</IncludeSourceRevisionInInformationalVersion>

image

To be investigated, is this only a problem in non-release builds? Or do we need to fix this?

@rwmcintosh rwmcintosh added this to v12 Mar 27, 2024
@rwmcintosh rwmcintosh added this to the Version 12 milestone Mar 27, 2024
@Yuri05 Yuri05 moved this to Accepted in v12 Apr 24, 2024
@rwmcintosh rwmcintosh changed the title Commit has included in version strings Commit ID included in version strings Apr 29, 2024
@rwmcintosh rwmcintosh self-assigned this Apr 29, 2024
@rwmcintosh rwmcintosh moved this from Accepted to In Progress in v12 Apr 29, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Fixed in v12 Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Fixed
Development

Successfully merging a pull request may close this issue.

1 participant