(New) Many WMP9 Video Playback fixes for Yuzusoft VN's #62
Conversation
|
Failed? Nothing is wrong with it, what am i supposed to change here? |
|
Thanks for the pull request. I'll test them in a bit since I own them, and I think it would probably be a good idea to create fixes in GOG or umu because they're available in other storefronts -- GOG and NekoNyan |
|
|
||
| def main(): | ||
| """ | ||
| """ |
There was a problem hiding this comment.
It's the empty docstring which is unnecessary. See the linter errors for more details
There was a problem hiding this comment.
and does this mean i have to submit another pull request with those gone in the script
|
To clarify, this fixes the video playback specifically for the opening and ending videos, correct? |
Yes, ive tested. In the normal playthrough they play with full video and sound. Replaying them through the scene select also has full video and sound |
|
i will now submit yet another Pull Request with the spaces gone so it can pass the checks. |
This will fix 100% WMP9 Video Playback for many Yuzusoft VN's, Including Riddle Joker. I am very certain this works, excluding even a single command will either cause a black screen, laggy or no audio or it just wont play. (I tested this very well)