Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for Persona 4 Golden on Steam #78

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

OlegAckbar
Copy link
Contributor

No description provided.

@R1kaB3rN
Copy link
Member

R1kaB3rN commented Jun 2, 2024

Do you mind providing more context for reinstating this fix? This was removed since 5188e66, so it should be fine now.

@tgurr for feedback

@OlegAckbar
Copy link
Contributor Author

I guess the Steam version doesn't need it since it probably ships re-encoded videos, but if you try to run the game outside Steam environment (e.g. to make DRM-free version with Goldberg emu) you'll have to re-encode in-game videos on your own PC and that will faild without wmp9, klite etc. Also, the game relies on d3dx11_43 which won't be installed since the Steam first-run process would never happen.

@tgurr
Copy link
Contributor

tgurr commented Jun 3, 2024

@tgurr for feedback

I can only comment on the Steam version/usage and also not sure if this project is intended to cover niche use-cases such as the one mentioned above forcing unneeded stuff for the majority of people and/or if it could be made optional by detecting if running "under" steam or not. For running under/with Steam workarounds are certainly not needed anymore.

I also can't spot a dedicated separate depot for the re-encoded video files on https://steamdb.info/app/1113000/depots/ so shouldn't everyone get them by default when downloading the latest version? (The game went through some major updates over the time even years after the initial release with it even moving to 64bit, additional subtitles and so on.)

@doZennn
Copy link
Contributor

doZennn commented Jun 3, 2024

I also can't spot a dedicated separate depot for the re-encoded video files on https://steamdb.info/app/1113000/depots/

Steam distributes transcoded media via the shader cache updates.

@tgurr
Copy link
Contributor

tgurr commented Jun 3, 2024

shader cache update

Interesting, good to know thanks! Off-topic: Is there some special-case handling implemented? I can remember having disabled downloading shader cache globally but Persona 4 still worked for me including playback of video.

@GloriousEggroll GloriousEggroll merged commit fe8af4a into Open-Wine-Components:master Jun 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants