Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various typos #189

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Fix various typos #189

merged 1 commit into from
Jan 4, 2022

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Nov 20, 2021

Found via codespell -q 3 -S ./scripts/spelling.txt

@arnopo arnopo requested review from arnopo and edmooring November 22, 2021 08:28
@arnopo
Copy link
Contributor

arnopo commented Nov 22, 2021

Hello @luzpaz
Nice tool! Please, could you fix your commit message by adding your signed-off?

Could you also tell me if it is possible to use the tool in a github action on a pool request? The idea would be to integrate your tool to check codespell on a PR.

@luzpaz
Copy link
Contributor Author

luzpaz commented Nov 22, 2021

Copy link
Contributor

@arnopo arnopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still an issue with gitlint as autor is luzpaz@users.noreply.github.com)
git commit --amend --author="luzpaz@users.noreply.github.com)" should fix this.

@arnopo
Copy link
Contributor

arnopo commented Nov 23, 2021

See https://github.com/codespell-project/actions-codespell
Thanks !
i will have a look to it

@arnopo arnopo added this to the Release V2022.04 milestone Nov 23, 2021
@luzpaz
Copy link
Contributor Author

luzpaz commented Nov 23, 2021

Still an issue with gitlint as autor is luzpaz@users.noreply.github.com) git commit --amend --author="luzpaz@users.noreply.github.com)" should fix this.

$ git commit --amend --author="luzpaz@users.noreply.github.com)"
fatal: --author 'luzpaz@users.noreply.github.com)' is not 'Name <email>' and matches no existing author

@arnopo no joy 😞

@edmooring
Copy link
Contributor

Still an issue with gitlint as autor is luzpaz@users.noreply.github.com) git commit --amend --author="luzpaz@users.noreply.github.com)" should fix this.

$ git commit --amend --author="luzpaz@users.noreply.github.com)"
fatal: --author 'luzpaz@users.noreply.github.com)' is not 'Name <email>' and matches no existing author

@arnopo no joy 😞

It looks like gitlint wants a "real" email address, you might try
git commit --amend --author="Luz Paz" <luzpaz@users.noreply.github.com>"
although it looks like gitlint also might not like anybody @users.noreply.github.com.

Found via `codespell -q 3 -S ./scripts/spelling.txt`

Signed-off-by: luz paz <luzpaz@users.noreply.github.com>
Copy link
Contributor

@edmooring edmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can live with the commit message now:)
The typo corrections are very welcome.

@arnopo arnopo merged commit 210b9ec into OpenAMP:main Jan 4, 2022
@luzpaz luzpaz deleted the typos branch January 4, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants