Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zephyr: update include paths to use <zephyr/...> #210

Merged
merged 2 commits into from
May 16, 2022

Conversation

gmarull
Copy link
Contributor

@gmarull gmarull commented May 10, 2022

Zephyr has prefixed all of its includes with <zephyr/...>. While the old
mode can still be used (CONFIG_LEGACY_INCLUDE_PATH) and is still enabled
by default, it's better to be prepared for its removal in the future.

gmarull added 2 commits May 10, 2022 15:02
Zephyr has prefixed all of its includes with <zephyr/...>. While the old
mode can still be used (CONFIG_LEGACY_INCLUDE_PATH) and is still enabled
by default, it's better to be prepared for its removal in the future.

Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
<zephyr/zephyr.h> is a shim to the Kernel header, so let's use it
directly.

Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
@gmarull
Copy link
Contributor Author

gmarull commented May 10, 2022

cc: @carlocaione

@arnopo arnopo requested review from arnopo and edmooring May 12, 2022 15:27
@arnopo
Copy link
Contributor

arnopo commented May 12, 2022

Hi @gmarull
your PR LGTM but I can't understand why there are 2 commits, can you explain it to me?
Else could you merge all in one?

@gmarull
Copy link
Contributor Author

gmarull commented May 12, 2022

@arnopo the first adds <zephyr/> prefix, the second changes <zephyr/zephyr.h> to <zephyr/kernel.h>.

Copy link
Contributor

@edmooring edmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@arnopo arnopo merged commit 8bb3fa3 into OpenAMP:main May 16, 2022
@arnopo arnopo added this to the Release V2022.10 milestone May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants