Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuttX: Add missing include header in IRQ implementation #230

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

gustavonihei
Copy link
Contributor

This PR intends to add a missing header to the irq.c file, which became evident after a code refactor in another component and resulted in the following build error:

libmetal/lib/system/nuttx/irq.c: In function ‘metal_cntr_irq_set_enable’:                                                                                                                                                                                                                 
libmetal/lib/system/nuttx/irq.c:34:25: error: implicit declaration of function ‘up_enable_irq’ [-Werror=implicit-function-declaration]                                                                                                                                                    
   34 |                         up_enable_irq(irq);                                                                                                                                                                                                                                       
      |                         ^~~~~~~~~~~~~                                                                                                                                                                                                                                             
libmetal/lib/system/nuttx/irq.c:36:25: error: implicit declaration of function ‘up_disable_irq’ [-Werror=implicit-function-declaration]                                                                                                                                                   
   36 |                         up_disable_irq(irq);                                                                                                                                                                                                                                      
      |                         ^~~~~~~~~~~~~~                                                                                                                                                                                                                                            
libmetal/lib/system/nuttx/irq.c: In function ‘metal_cntr_irq_attach’:                                                                                                                                                                                                                     
libmetal/lib/system/nuttx/irq.c:73:17: error: implicit declaration of function ‘irq_dispatch’; did you mean ‘irq_detach’? [-Werror=implicit-function-declaration]                                                                                                                         
   73 |                 irq_dispatch(irq, NULL); /* fake a irq request */                                                                                                                                                                                                                 
      |                 ^~~~~~~~~~~~                                                                                                                                                                                                                                                      
      |                 irq_detach                                                                                                                                                                                                                                                        
cc1: all warnings being treated as errors                                                                                                                                                                                                                                                 
make[1]: *** [Makefile:43: libmetal/lib/system/nuttx/irq.o] Error 1

Missing header became evident after a code refactor in another NuttX
component, which resulted in build warnings.

Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com>
@gustavonihei gustavonihei force-pushed the bugfix/nuttx_include branch from 7d439b5 to d9374a1 Compare March 7, 2023 13:32
Copy link
Contributor

@edmooring edmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@arnopo arnopo self-requested a review March 14, 2023 18:01
@arnopo arnopo requested a review from xiaoxiang781216 March 14, 2023 18:03
@arnopo arnopo added this to the Release V2023.04 milestone Mar 14, 2023
@arnopo arnopo merged commit 5a87db2 into OpenAMP:main Mar 23, 2023
@gustavonihei gustavonihei deleted the bugfix/nuttx_include branch March 27, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants