Add Versal SOC family support #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnopo
requested changes
Jun 5, 2023
| #endif /* defined(versal) */ | ||
|
|
||
| #define MB (1024 * 1024UL) | ||
| #define GB (1024 * 1024 * 1024UL) |
There was a problem hiding this comment.
Seems that thes definitions are used in several files... could be moved to utilities.h, the update of the other files can be done later
There was a problem hiding this comment.
ok will move this. thank you
bentheredonethat
force-pushed
the
versal_family_support
branch
from
230be12 to
8833cec
Compare
|
@arnopo updated copyrights |
|
also moved the MB/GB part to utilities.h |
arnopo
requested changes
Jun 19, 2023
| collect (PROJECT_LIB_HEADERS sys.h) | ||
|
|
||
| add_subdirectory(../xlnx_common ${CMAKE_CURRENT_BINARY_DIR}/../xlnx_common) | ||
| # vim: expandtab:ts=2:sw=2:smartindent |
There was a problem hiding this comment.
to remove vim line ( and you can also remove some other instances)
bentheredonethat
force-pushed
the
versal_family_support
branch
from
8833cec to
d25311b
Compare
|
Hi @arnopo are there any pending changes? |
arnopo
requested changes
Jun 22, 2023
| @@ -1,6 +1,4 @@ | |||
| collect (PROJECT_LIB_HEADERS sys.h) | |||
|
|
|||
| collect (PROJECT_LIB_SOURCES sys.c) | |||
|
|
|||
| add_subdirectory(../xlnx_common ${CMAKE_CURRENT_BINARY_DIR}/../xlnx_common) | |||
| # vim: expandtab:ts=2:sw=2:smartindent | |||
There was a problem hiding this comment.
resolved @arnopo
| collect (PROJECT_LIB_HEADERS sys.h) | ||
|
|
||
| add_subdirectory(../xlnx_common ${CMAKE_CURRENT_BINARY_DIR}/../xlnx_common) | ||
| # vim: expandtab:ts=2:sw=2:smartindent |
bentheredonethat
force-pushed
the
versal_family_support
branch
from
d25311b to
6c31f40
Compare
|
removed the vim line in new commits |
arnopo
approved these changes
Jun 27, 2023
| #include "xreg_cortexa53.h" | ||
| #endif /* defined(versal) */ | ||
|
|
||
|
|
There was a problem hiding this comment.
./scripts/checkpatch.pl --strict --codespell 237.patch
237.patch:87: CHECK:LINE_SPACING: Please don't use multiple blank lines
#87: FILE: lib/system/generic/xlnx_common/zynqmp_aarch64/sys.c:28:
+
+
There was a problem hiding this comment.
Sorry! thanks @arnopo i ran checkpatch and the only remaining lines are due to Xilinx-BSP functions now (same as it was). latest commits reflect the fix. thanks
Enable cache, IPI, exception and shared-memory operations on Versal A72 for Libmetal. Additionally, as the code for A72 and A53 is almost identical, move the common code to generic/xlnx_common/zynqmp_aarch64 and differentiate the slight differences with macro checks. Signed-off-by: Ben Levinsky <ben.levinsky@xilinx.com> Acked-by: tanmay.shah@xilinx.com
Enable cache, IPI, exception and shared-memory operations on Versal A78 for Libmetal. Signed-off-by: Ben Levinsky <ben.levinsky@amd.com>
bentheredonethat
force-pushed
the
versal_family_support
branch
from
6c31f40 to
c3ca569
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Versal and Versal_Net SoCs APU cores A72 and A78