Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: refactor alloc.h to not need forward declaration #245

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

glneo
Copy link
Contributor

@glneo glneo commented Jul 10, 2023

This should have no functional change, but makes this header consistent with how the other headers are organized.

This should have no functional change, but makes this header consistent
with how the other headers are organized.

Signed-off-by: Andrew Davis <afd@ti.com>
@arnopo arnopo requested review from edmooring, tnmysh and arnopo July 11, 2023 15:34
@arnopo
Copy link
Contributor

arnopo commented Jul 11, 2023

Hi @glneo,
Thanks to try to make libmetal API more consistent.
Could you share with us what led you to propose this PR. Did you encounter any particular problem?

@glneo
Copy link
Contributor Author

glneo commented Jul 11, 2023

This is part of a larger set of refactoring that should culminate in the addition of support for TI devices.

The later changes make more sense and are easier to comprehend when the headers are more consistent. This change was sent separate as it should be trivially correct and can stand alone. Helps us test the waters with this project.

@tnmysh
Copy link
Collaborator

tnmysh commented Aug 2, 2023

Looks good to me.

Copy link
Contributor

@edmooring edmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go.

@arnopo arnopo merged commit f2144b1 into OpenAMP:main Aug 16, 2023
@arnopo arnopo added this to the Release V2023.10 milestone Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants