Export each of the memory_order enumerators #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lib/atomic.h exports memory_order enum into the global namespace, but none of its enumerators. According to Section 7.3.3 "The using declaration" of the C++ standard: "specifying an enumeration name in a using-declaration does not declare its enumerators in the using-declaration's declarative region." See also: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0943r1.html Signed-off-by: Sergei Korneichuk <sergei.korneichuk@amd.com>
|
Hi @edmooring, I'll have to update the Copyright in the file. |
|
@kernelchuk sorry for the delay! This seems sensible to me 👍🏻 |
tnmysh
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lib/atomic.h exports memory_order enum into the global namespace, but none of its enumerators. According to Section 7.3.3 "The using declaration" of the C++ standard: "specifying an enumeration name in a using-declaration does not declare its enumerators in the using-declaration's declarative region." See also: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0943r1.html