lib: utilities: add MB and GB defines #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If MB and GB definition is not available then define new ones Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
tnmysh
commented
Aug 17, 2023
| #define MB (1024 * 1024UL) | ||
| #define GB (1024 * 1024 * 1024UL) | ||
| #ifndef MB | ||
| #define MB (1024UL << 10UL) |
There was a problem hiding this comment.
I have question here. Since MB and GB are so common terms, should we check values compile time of MB and GB if they are defined somewhere else ?
For example:
#ifndef MB
...
#else
#if (MB != (1024 * 1024))
#error "error: unexpected value of MB"
#endif
something like this? Since MB can be defined as 1000 * 1000.
I am asking since want to know if it's overkill and we can simply assume that everywhere it will be defined as 1024 * 1024.
Thanks,
Tanmay
There was a problem hiding this comment.
For me we can assume that MB is defined as 1024 *1024.
arnopo
approved these changes
Aug 21, 2023
| #define MB (1024 * 1024UL) | ||
| #define GB (1024 * 1024 * 1024UL) | ||
| #ifndef MB | ||
| #define MB (1024UL << 10UL) |
There was a problem hiding this comment.
For me we can assume that MB is defined as 1024 *1024.
|
@edmooring |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If MB and GB definition is not available then define new ones.
This also addresses: #242