Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements in entrypoint CI script #266

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Minor improvements in entrypoint CI script #266

merged 3 commits into from
Oct 16, 2023

Conversation

aescolar
Copy link
Contributor

@aescolar aescolar commented Oct 15, 2023 •
edited
Loading

A few minor changes to the CI script to reduce considerably the log size and do a minor speed up.
There are 3 main changes:

  • wget prints less as it progresses (one dot per megabyte instead of KB) (~10K lines saved)
  • The zephyr SDK extraction, instead of printing one line per file (~50K lines), it prints a progress bar updated every 3 seconds.
  • west does a narrow update instead of a full update (only fetching the needed branch for each repo)

@aescolar aescolar changed the title Better ci Minor improvements in entrypoint CI script Oct 15, 2023
@aescolar aescolar force-pushed the better_ci branch 7 times, most recently from 9de217f to 960ceeb Compare October 15, 2023 10:02
@aescolar aescolar marked this pull request as ready for review October 15, 2023 10:17
@arnopo
Copy link
Contributor

arnopo commented Oct 16, 2023 •
edited
Loading

Thanks for the improvement: 2637 lines in log instead of more than 78000.
Could you please re-base it on main , that integrates the fix for the Zephyr CI?

@aescolar
CI: Zephyr build: Be less verbose
d3d9aa7 
* Do not run the tar extract verbose, as
  that generated ~50.000 lines of output slowing down
  things and generating a huge log.
* Reduce the progress output of wget to only print one dot
  every megabyte, instead of every kilobyte reducing a lot
  the log output.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
@aescolar
CI: Fix entrypoint indentation
3d4caca 
The file had a mix of spaces and tabs for indentation
Fix it.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
@aescolar
CI: Zephyr: Only fetch needed branches instead of everything
d5b7b02 
Have west only fetch the needed branches instead of doing
a full clone of all repositories.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
@aescolar
Copy link
Contributor Author

aescolar commented Oct 16, 2023 •
edited by arnopo
Loading

Thanks for the improvement: 2637 lines in log instead of more than 78000. Could you please re-base it on main , that integrates the fix for the Zephyr CI?

You are very welcome. It has been rebased and CI is green now :)

@arnopo
Copy link
Contributor

arnopo commented Oct 16, 2023

I merged it without more reviews as it concerns only CI improvement.

@arnopo arnopo merged commit 549f13b into OpenAMP:main Oct 16, 2023
3 checks passed
@arnopo arnopo added this to the Release V2023.10 milestone Oct 16, 2023
@aescolar aescolar deleted the better_ci branch October 16, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmooring edmooring Awaiting requested review from edmooring

@arnopo arnopo Awaiting requested review from arnopo

@wmamills wmamills Awaiting requested review from wmamills

@tnmysh tnmysh Awaiting requested review from tnmysh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release V2023.10
Development

Successfully merging this pull request may close these issues.
2 participants
@aescolar @arnopo