Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: add guards for errno values for ARMCC compiler #271

Merged
merged 1 commit into from
Nov 6, 2023
Merged

lib: add guards for errno values for ARMCC compiler #271

merged 1 commit into from
Nov 6, 2023

Conversation

ldaj00
Copy link
Contributor

@ldaj00 ldaj00 commented Oct 24, 2023

The new guards prevent redefinition of errno values which have already been defined in the standard libraries.

@arnopo arnopo requested review from edmooring, arnopo and tnmysh October 27, 2023 12:38
arnopo
arnopo approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@arnopo arnopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Please, could you rebase on on top af main branch that fixes the CI issue.

edmooring
edmooring approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@edmooring edmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go.

@arnopo
Copy link
Contributor

arnopo commented Nov 2, 2023

@ldaj00
The Merge branch 'OpenAMP:main' into armcc-errno-guards commit should not be part of the PR, please force your armcc-errno-guards branch to be on to of the main branch lib: add guards for errno values for ARMCC compiler commit

@arnopo
Copy link
Contributor

arnopo commented Nov 2, 2023

In addition, as ARMCC compiler user, could give feedback on #270?
Thanks in advance.

@ldaj00
lib: add guards for errno values for ARMCC compiler
504a8ef 
The new guards prevent redefinition of errno values which have already
been defined in the standard libraries.

Signed-off-by: Ledion Daja <ledion.daja@arm.com>
@ldaj00 ldaj00 force-pushed the armcc-errno-guards branch from 7aeec2b to 504a8ef Compare November 3, 2023 08:36
@ldaj00
Copy link
Contributor Author

ldaj00 commented Nov 3, 2023 •
edited
Loading

@arnopo Thanks for catching the merge commit. It should be fixed now.

could give feedback on #270?

Ack, will do.

@arnopo arnopo merged commit 8041e1c into OpenAMP:main Nov 6, 2023
3 checks passed
@arnopo arnopo added this to the Release V2024.04 milestone Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnmysh tnmysh tnmysh approved these changes

@arnopo arnopo arnopo approved these changes

@edmooring edmooring edmooring approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release V2024.05
Development

Successfully merging this pull request may close these issues.
4 participants
@ldaj00 @arnopo @edmooring @tnmysh