Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: xlnx: Avoid mapping in MPU for region mapped by bsp #282

Merged
merged 1 commit into from
Feb 19, 2024
Merged

lib: xlnx: Avoid mapping in MPU for region mapped by bsp #282

merged 1 commit into from
Feb 19, 2024

Conversation

tnmysh
Copy link
Collaborator

@tnmysh tnmysh commented Jan 15, 2024

Avoiding memory mapping in MPU config table for region that are already mapped by bsp and no change in attribute property.

@tnmysh
Copy link
Collaborator Author

tnmysh commented Jan 15, 2024

This work is in progress. Creating draft PR for keeping track of updates.

@tnmysh tnmysh self-assigned this Jan 15, 2024
@tnmysh
Copy link
Collaborator Author

tnmysh commented Jan 23, 2024

Changes in v2:

  • Remove CamelCasing for variables defined in libmetal code.
  • Fix spacing related warnings.

@tnmysh tnmysh marked this pull request as ready for review January 24, 2024 18:09
@tnmysh
Copy link
Collaborator Author

tnmysh commented Jan 24, 2024

@arnopo, @edmooring for reviews.

@arnopo arnopo requested review from edmooring and arnopo January 25, 2024 16:25
@tnmysh
Copy link
Collaborator Author

tnmysh commented Jan 25, 2024

This is workaround while this issue is resolved: #283

arnopo
arnopo approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@arnopo arnopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed during the OpenAMP call, the current code can serve as a temporary workaround.
However, in the long term, for the sys.c, the objective is file to act as a simple wrapper that calls an AMD system HAL outside of libmetal. This AMD HAL should address this kind of specificity.

@tnmysh
Copy link
Collaborator Author

tnmysh commented Jan 29, 2024

As we discussed during the OpenAMP call, the current code can serve as a temporary workaround.
However, in the long term, for the sys.c, the objective is file to act as a simple wrapper that calls an AMD system HAL outside of libmetal. This AMD HAL should address this kind of specificity.

Ack.

@tnmysh
Copy link
Collaborator Author

tnmysh commented Jan 31, 2024 •
edited
Loading

Updated correct author signature. The patch is the same.

@tnmysh
Copy link
Collaborator Author

tnmysh commented Feb 9, 2024

@edmooring ping for reviews.

edmooring
edmooring requested changes Feb 10, 2024
View reviewed changes
Copy link
Contributor

@edmooring edmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, looks good for now.

lib/system/generic/xlnx/sys.c Outdated Show resolved Hide resolved
@rajimoha @tnmysh
lib: xlnx: Avoid mapping in MPU for region mapped by bsp
08b9151 
Avoiding memory mapping in MPU config table for region that are already
mapped by bsp and no change in attribute property.

Signed-off-by: Rajiv Mohan <rajiv.mohan@amd.com>
Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
@tnmysh tnmysh requested a review from edmooring February 13, 2024 14:03
@tnmysh
Copy link
Collaborator Author

tnmysh commented Feb 13, 2024

@edmooring addressed comment as requested. Ping for reviews.

edmooring
edmooring approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@edmooring edmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go.

@arnopo arnopo merged commit 3517a07 into OpenAMP:main Feb 19, 2024
3 of 4 checks passed
@arnopo arnopo added this to the Release V2024.04 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnopo arnopo arnopo approved these changes

@edmooring edmooring edmooring approved these changes

Assignees

@tnmysh tnmysh

Labels
None yet
Projects
None yet
Milestone
Release V2024.05
Development

Successfully merging this pull request may close these issues.
4 participants
@tnmysh @edmooring @arnopo @rajimoha