CI: fix zephyr build for v3.7 and later #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmamills
force-pushed
the
wam-fix-zephyr-ci
branch
2 times, most recently
from
8886ec7 to
b5f4767
Compare
The current CI uses the latest from main for zephyr build tests. This has been broken sometime after v3.6 and before v3.7. Since that time, use of GNU style constructors requires a kconfig value to be defined. This same kconfig value will cause an error in v3.6 or earlier. The test framework intentionally uses GNU constructors for the base level of its framework and version.c uses this to register its test. The test/system/zephyr/ level overrides the default META_ADD_TEST() macro and creates unique functions that main.c then calls explicitly in function metal_test_add_functions(). Thus, right now the only constructor used if for version.c but it still intentionally used. Since we use the latest for CI, define the value so CI will complete. Signed-off-by: Bill Mills <bill.mills@linaro.org>
wmamills
force-pushed
the
wam-fix-zephyr-ci
branch
from
b5f4767 to
42eb740
Compare
arnopo
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current CI uses the latest from main for zephyr build tests. This has been broken sometime after v3.6 and before v3.7 In Zephyr v3.7 and later, use of GNU style constructors requires a kconfig value to be defined. This same kconfig value will cause an error in v3.6 or earlier.
The test framework intentionally uses GNU constructors for the base level of its framework and version.c uses this to register its test.
The test/system/zephyr/ level overrides the default META_ADD_TEST() macro and creates unique functions that main.c then calls explicitly in function metal_test_add_functions().
Thus, right now the only constructor used is for version.c but it still intentionally used.
Since we use the latest for CI, define the value so CI will complete.
Fixes: #304