-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function header description consistency #478
Conversation
The purpose of this PR is to see a sample of the changes I am proposing for all the API function headers. |
Look good to go with this function header formatting. |
e74109c
to
d8850d1
Compare
@arnopo Is there a way to override the failure of the checker not recognizing the word "doesn't"? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems correct but I need to apply it for a more complete review.
in a first step could you split in 2 commits, a separate one to fix the Doxyfile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @arnopo is there a way to have checkpatch look for this automatically?
you mean check the header syntax for doxygen? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
I have few comments.
Some can be addressed in a next step.
* @param data Payload of the message | ||
* @param len Length of the payload | ||
* | ||
* @return Number of bytes it has sent or negative error value on failure. | ||
*/ | ||
static inline int rpmsg_send(struct rpmsg_endpoint *ept, const void *data, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems that doxygen does not generate the documentation for static function. I don't know if there is a way to force it.... do you have a simple solution?
An alternative (which would get advantage to improve the support of RUST client) would be an implementation similar to
this proposal:
OpenAMP/libmetal@ef0a476
For this release we can just enter an issue to fix that later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arnopo I think we should fix it according to the ticket you quote, but maybe not for this release since I foresee a lot of back and forth with that solution. I can set EXTRACT_STATIC to YES to resolve for Doxygen, and I will open a ticket for additional changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, Let treat "static" declaration issue in a next step and get this one for this release.
Updated function header descriptions formatting to be consistent. Signed-off-by: Tammy Leino <tammy.leino@siemens.com>
Set tabs to 8 spaces and enabled doc generation for static functions. Signed-off-by: Tammy Leino <tammy.leino@siemens.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go.
Updated function header descriptions formatting to be consistent.
Signed-off-by: Tammy Leino tammy.leino@siemens.com