-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring in changes from joschi/openapi-diff #159
Conversation
Fix issue #53
Bumps [maven-source-plugin](https://github.com/apache/maven-source-plugin) from 3.1.0 to 3.2.1. - [Release notes](https://github.com/apache/maven-source-plugin/releases) - [Commits](apache/maven-source-plugin@maven-source-plugin-3.1.0...maven-source-plugin-3.2.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [assertj-core](https://github.com/joel-costigliola/assertj-core) from 3.14.0 to 3.15.0. - [Release notes](https://github.com/joel-costigliola/assertj-core/releases) - [Commits](assertj/assertj@assertj-core-3.14.0...assertj-core-3.15.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [lombok](https://github.com/rzwitserloot/lombok) from 1.18.10 to 1.18.12. - [Release notes](https://github.com/rzwitserloot/lombok/releases) - [Changelog](https://github.com/rzwitserloot/lombok/blob/master/doc/changelog.markdown) - [Commits](projectlombok/lombok@v1.18.10...v1.18.12) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.1.1 to 3.2.0. - [Release notes](https://github.com/apache/maven-javadoc-plugin/releases) - [Commits](apache/maven-javadoc-plugin@maven-javadoc-plugin-3.1.1...maven-javadoc-plugin-3.2.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [githook-maven-plugin](https://github.com/phillipuniverse/githook-maven-plugin) from 1.0.4 to 1.0.5. - [Release notes](https://github.com/phillipuniverse/githook-maven-plugin/releases) - [Commits](phillipuniverse/githook-maven-plugin@1.0.4...1.0.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Adding a new read-only property into an API model should be considered a breaking change for PUT operations. A client not knowing of the new read-only property would get a resource from the API which includes the new read-only property and would send a full update back via PUT omitting that new property. The result is that the property would be cleared on the server side as the client did not sent the retrieved value back.
Bumps `junit.jupiter.version` from 5.5.2 to 5.6.2. Updates `junit-jupiter-engine` from 5.5.2 to 5.6.2 - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.5.2...r5.6.2) Updates `junit-jupiter-api` from 5.5.2 to 5.6.2 - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.5.2...r5.6.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Remove `--output` parameter, add `--text` parameter for text output into a file, and allow all of them, `--html`, `--markdown` and `--text`, at the same time instead of only one. The `--output` parameter is not needed because the same functionality is provided by `--html`, `--markdown`, and `--text` in a more intuitive way.
Instead of always failing when the API changed, this behavior is now triggered by `--fail-on-changed`. The normal behavior is now to print the report and exit successfully.
Note: swagger-parser 2.0.19 is more strict than earlier versions
Bumps [assertj-core](https://github.com/joel-costigliola/assertj-core) from 3.14.0 to 3.16.1. - [Release notes](https://github.com/joel-costigliola/assertj-core/releases) - [Commits](assertj/assertj@assertj-core-3.14.0...assertj-core-3.16.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
`HtmlRender` and `MarkdownRender` failed to resolve component schemas which had been removed in the "new" OpenAPI specification and threw an `IllegalArgumentException`. Refs #7
Bumps commons-lang3 from 3.10 to 3.11. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps `swagger-parser.version` from 2.0.20 to 2.0.21. Updates `swagger-parser-v3` from 2.0.20 to 2.0.21 Updates `swagger-parser` from 2.0.20 to 2.0.21 - [Release notes](https://github.com/swagger-api/swagger-parser/releases) - [Commits](swagger-api/swagger-parser@v2.0.20...v2.0.21) Updates `swagger-parser-v2-converter` from 2.0.20 to 2.0.21 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Hi @joschi thank you for you work ! |
This reverts commit cef8549.
I removed it because I don't have access to your CircleCI account (for example to trigger rebuilding commits) and I've been using GitHub Actions for building the project in my fork: |
Bring the bug fixes and changes (such as splitting the openapi-diff artifacts) from https://github.com/joschi/openapi-diff/ into the canonical repository before migrating to @OpenAPITools.
@quen2404 Should we revert the changes to the artifact coordinates (Maven and Docker image) or should we change them to the @OpenAPITools specific coordinates once the repository moved?