Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in changes from joschi/openapi-diff #159

Merged
merged 67 commits into from
Aug 27, 2020

Conversation

joschi
Copy link
Contributor

@joschi joschi commented Aug 19, 2020

Bring the bug fixes and changes (such as splitting the openapi-diff artifacts) from https://github.com/joschi/openapi-diff/ into the canonical repository before migrating to @OpenAPITools.

@quen2404 Should we revert the changes to the artifact coordinates (Maven and Docker image) or should we change them to the @OpenAPITools specific coordinates once the repository moved?

quen2404 and others added 30 commits July 25, 2018 10:48
Adding a new read-only property into an API model should be considered a breaking change for PUT operations. A client not knowing of the new read-only property would get a resource from the API which includes the new read-only property and would send a full update back via PUT omitting that new property. The result is that the property would be cleared on the server side as the client did not sent the retrieved value back.
Bumps `junit.jupiter.version` from 5.5.2 to 5.6.2.

Updates `junit-jupiter-engine` from 5.5.2 to 5.6.2
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](junit-team/junit5@r5.5.2...r5.6.2)

Updates `junit-jupiter-api` from 5.5.2 to 5.6.2
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](junit-team/junit5@r5.5.2...r5.6.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Remove `--output` parameter, add `--text` parameter for text output into a file, and allow all of them, `--html`, `--markdown` and `--text`, at the same time instead of only one.

The `--output` parameter is not needed because the same functionality is provided by `--html`, `--markdown`, and `--text` in a more intuitive way.
Instead of always failing when the API changed, this behavior is now triggered by `--fail-on-changed`.

The normal behavior is now to print the report and exit successfully.
Note: swagger-parser 2.0.19 is more strict than earlier versions
joschi and others added 21 commits June 24, 2020 09:52
`HtmlRender` and `MarkdownRender` failed to resolve component schemas which had been removed in the "new" OpenAPI specification and threw an `IllegalArgumentException`.

Refs #7
Bumps commons-lang3 from 3.10 to 3.11.

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps `swagger-parser.version` from 2.0.20 to 2.0.21.

Updates `swagger-parser-v3` from 2.0.20 to 2.0.21

Updates `swagger-parser` from 2.0.20 to 2.0.21
- [Release notes](https://github.com/swagger-api/swagger-parser/releases)
- [Commits](swagger-api/swagger-parser@v2.0.20...v2.0.21)

Updates `swagger-parser-v2-converter` from 2.0.20 to 2.0.21

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@joschi joschi requested a review from quen2404 August 19, 2020 06:29
@joschi joschi self-assigned this Aug 19, 2020
@quen2404
Copy link
Member

Hi @joschi thank you for you work !
I think we will change it after the move to openapitools.
I saw you remove the .circleci file ? Why ? Can you add it again ?

@quen2404 quen2404 merged commit 96f20ff into OpenAPITools:master Aug 27, 2020
@joschi
Copy link
Contributor Author

joschi commented Aug 27, 2020

I saw you remove the .circleci file ? Why ? Can you add it again ?

I removed it because I don't have access to your CircleCI account (for example to trigger rebuilding commits) and I've been using GitHub Actions for building the project in my fork:
https://github.com/joschi/openapi-diff/actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing execution field in pom.xml in release 1.2.0
5 participants