[build] Master/PR/Release workflows #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
joschi
reviewed
Oct 13, 2020
.github/workflows/maven.yml
Outdated
| run: ./mvnw -V -B -ntp -ff install '-DskipTests=true' '-Dmaven.javadoc.skip=true' | ||
| - name: Run tests | ||
| run: ./mvnw -V -B -ntp -ff verify | ||
| run: ./mvnw -V -B -ntp -ff clean verify |
There was a problem hiding this comment.
Since we're running from scratch every time the workflow is being executed, the clean phase can be skipped.
There was a problem hiding this comment.
I'm not familiar enough with the project to comment on this. However, it's usually best practice to ensure outputs are cleaned through the build tool before running a build in case there are any stale build outputs inadvertently committed to source.
.github/workflows/pr.yml
Outdated
| restore-keys: | | ||
| ${{ runner.os }}-maven- | ||
| - name: Run tests | ||
| run: ./mvnw -V -B -ntp -ff clean verify |
There was a problem hiding this comment.
Since we're running from scratch every time the workflow is being executed, the clean phase can be skipped.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on #172 before merging this.
This breaks master build from pull request builds, which will have different use cases.
Creates a release workflow which can be triggered manually from the actions tab in GitHub. This will tag/release automatically, and rollback if necessary. I haven't tested it, but it should work as-is.